From 265daa00d977ffac6055d7c74953a34408acbf98 Mon Sep 17 00:00:00 2001
From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Date: Mon, 9 Oct 2023 14:05:24 +0000
Subject: [PATCH 1/4] We can start failing on the CI for real.
---
eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml b/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
index c641821da3855a..e9c26fbed48f84 100644
--- a/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
+++ b/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
@@ -117,9 +117,6 @@ jobs:
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
# Always run for runtime-wasm because tests are not run in runtime
alwaysRun: ${{ parameters.isWasmOnlyBuild }}
-
- # NOTE - Since threading is experimental, we don't want to block mainline work
- shouldContinueOnError: true
scenarios:
- WasmTestOnBrowser
#- WasmTestOnNodeJS - this is not supported yet, https://github.com/dotnet/runtime/issues/85592
From b0a6a8a96b10476b6151af8263ef0a05c5751065 Mon Sep 17 00:00:00 2001
From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Date: Mon, 9 Oct 2023 14:07:10 +0000
Subject: [PATCH 2/4] Fix 404 "Error during WebSocket handshake"
---
src/mono/wasm/runtime/loader/worker.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mono/wasm/runtime/loader/worker.ts b/src/mono/wasm/runtime/loader/worker.ts
index a22c65fcb78813..01b5d23c92264d 100644
--- a/src/mono/wasm/runtime/loader/worker.ts
+++ b/src/mono/wasm/runtime/loader/worker.ts
@@ -39,7 +39,7 @@ function onMonoConfigReceived(config: MonoConfigInternal): void {
loaderHelpers.afterConfigLoaded.promise_control.resolve(loaderHelpers.config);
if (ENVIRONMENT_IS_WEB && config.forwardConsoleLogsToWS && typeof globalThis.WebSocket != "undefined") {
- loaderHelpers.setup_proxy_console("pthread-worker", console, self.location.href);
+ loaderHelpers.setup_proxy_console("pthread-worker", console, globalThis.location.origin);
}
}
From 8a0b09461cd7dec6dc3a45d6038d0e58f5b0bd3f Mon Sep 17 00:00:00 2001
From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Date: Mon, 9 Oct 2023 18:15:37 +0000
Subject: [PATCH 3/4] Blocking
---
src/libraries/tests.proj | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj
index 4af1caa2bd52c2..643112882dc637 100644
--- a/src/libraries/tests.proj
+++ b/src/libraries/tests.proj
@@ -57,6 +57,7 @@
+
@@ -370,12 +371,6 @@
-
-
-
-
-
-
@@ -385,6 +380,15 @@
+
+
+
+
+
+
+
+
+
From 629880e28834561753e955f05a29c1e1d46dcdd2 Mon Sep 17 00:00:00 2001
From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Date: Tue, 10 Oct 2023 09:05:17 +0000
Subject: [PATCH 4/4] Fail on error + whitespaces.
---
eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml | 3 +++
src/libraries/tests.proj | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml b/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
index e9c26fbed48f84..c641821da3855a 100644
--- a/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
+++ b/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
@@ -117,6 +117,9 @@ jobs:
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
# Always run for runtime-wasm because tests are not run in runtime
alwaysRun: ${{ parameters.isWasmOnlyBuild }}
+
+ # NOTE - Since threading is experimental, we don't want to block mainline work
+ shouldContinueOnError: true
scenarios:
- WasmTestOnBrowser
#- WasmTestOnNodeJS - this is not supported yet, https://github.com/dotnet/runtime/issues/85592
diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj
index 643112882dc637..0b0a75f1063aca 100644
--- a/src/libraries/tests.proj
+++ b/src/libraries/tests.proj
@@ -387,8 +387,6 @@
-
-