Add CentOS 8 CI build

We have had some issues building in RHEL 8, so lets set up a CentOS 8 CI
system to try and catch those issues earlier.

Author: omajid

.vsts.pipelines/builds/matrix.yml

@@ -29,6 +29,18 @@ jobs:
     matrix:
       Offline: { type: Offline}
 
+- template: ../jobs/ci-linux.yml
+  parameters:
+    job: centos8
+    imageName: mcr.microsoft.com/dotnet-buildtools/prereqs:centos-8-daa5116-20200325130212
+    reportPrebuiltLeaks: false
+    systemLibunwind: false
+    matrix:
+      Production: { generatePrebuiltBurndown: true, runUnitTests: true }
+      Online: { type: Online }
+      Offline: { type: Offline }
+      Offline Portable: { type: Offline Portable }
+
 - template: ../jobs/ci-linux.yml
   parameters:
     job: debian9

.vsts.pipelines/jobs/ci-linux.yml

@@ -35,6 +35,7 @@ jobs:
     generatePrebuiltBurndown: ${{ parameters.generatePrebuiltBurndown }}
     rootDirectory: $(Build.SourcesDirectory)/..
     stagingDirectory: $(rootDirectory)/sb/staging
+    systemLibunwind: ${{ parameters.systemLibunwind }}
     tarballName: tarball_$(Build.BuildId)
     SOURCE_BUILD_SKIP_SUBMODULE_CHECK: true
     # Default type, can be overridden by matrix legs.
@@ -66,6 +67,7 @@ jobs:
       $(docker.run) $(docker.src.map) $(docker.src.work) $(imageName) ./build.sh \
         /p:Configuration=$(sb.configuration) \
         /p:PortableBuild=$(sb.portable) \
+        /p:UseSystemLibunwind=$(systemLibunwind) \
         /p:ArchiveDownloadedPackages=$(sb.tarball) \
         /p:FailOnPrebuiltBaselineError=$failOnBaselineError \
         /p:ProdConBlobFeedUrlPrefix=$(prodConBlobFeedUrlPrefix) \

dir.props

@@ -13,6 +13,7 @@
     <PortableBuild Condition="'$(OS)' == 'Windows_NT'">true</PortableBuild>
     <PortableBuild Condition="'$(PortableBuild)' == ''">false</PortableBuild>
     <UseSystemLibraries Condition="'$(UseSystemLibraries)' == '' AND '$(PortableBuild)' != 'true'">true</UseSystemLibraries>
+    <UseSystemLibunwind Condition="'$(UseSystemLibunwind)' == ''">$(UseSystemLibraries)</UseSystemLibunwind>
     <UseStableVersions Condition="'$(UseStableVersions)' == ''">true</UseStableVersions>
   </PropertyGroup>
 

repos/coreclr.common.props

@@ -9,7 +9,7 @@
     <BuildArguments Condition="'$(OS)' != 'Windows_NT'">$(BuildArguments) -skiprestore</BuildArguments>
     <BuildArguments Condition="'$(SkipDisablePgo)' != 'true'">$(BuildArguments) -nopgooptimize</BuildArguments>
     <BuildArguments Condition="'$(OS)' != 'Windows_NT'">$(BuildArguments) msbuildonunsupportedplatform</BuildArguments>
-    <BuildArguments Condition="'$(UseSystemLibraries)' == 'true' AND '$(OS)' != 'Windows_NT'">$(BuildArguments) cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=TRUE</BuildArguments>
+    <BuildArguments Condition="'$(UseSystemLibunwind)' == 'true' AND '$(OS)' != 'Windows_NT'">$(BuildArguments) cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=TRUE</BuildArguments>
     <BuildArguments Condition="$(Platform.Contains('arm')) AND '$(BuildArchitecture)' != 'arm64' ">$(BuildArguments) skipnuget cross -skiprestore cmakeargs -DFEATURE_GDBJIT=TRUE</BuildArguments>
     <BuildArguments Condition="'$(TargetOS)' == 'FreeBSD'">$(BuildArguments) -clang6.0 /p:PortableBuild=true</BuildArguments>