Skip to content

Don't do anything unusual to build portable or non-portable builds #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
7 tasks
crummel opened this issue May 24, 2019 · 1 comment
Closed
7 tasks

Don't do anything unusual to build portable or non-portable builds #1045

crummel opened this issue May 24, 2019 · 1 comment
Labels
area-build Improvements in source-build's own build process area-upstream-fix Needs a change in a contributing repo Epic Groups multiple user stories. Can be grouped under a theme.

Comments

@crummel
Copy link
Contributor

crummel commented May 24, 2019 •
edited
Loading

Currently source-build uses patches and extra properties to be able to build both portable and non-portable SDKs.
Final goal:

  • All repos that can change portableness supply one easy way to choose portable or non-portable build.
  • Source-build supports both portable and non-portable builds on all applicable platforms.
  • It does this uses only the standard build switches for each repository, no extra properties or patches.
  • Portableness is specified explicitly in all cases where it applies.
  • "No extra properties" includes not specifying RIDs, whether for "which packages to download" or "which packages to produce".
    • This means we can eliminate our dependency on RuntimeEnvironment checks to determine a RID before the build runs.
  • Source-build can build both portable and non-portable builds using either a portable (probably official) SDK or a non-portable (probably source-built) SDK.

Related: #696, #660, #750.
@crummel crummel added area-upstream-fix Needs a change in a contributing repo area-build Improvements in source-build's own build process labels May 24, 2019
@dseefeld dseefeld added the Epic Groups multiple user stories. Can be grouped under a theme. label Jul 18, 2019
@MichaelSimons
Copy link
Member

[Triage] Closing in favor of #2932.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-build Improvements in source-build's own build process area-upstream-fix Needs a change in a contributing repo Epic Groups multiple user stories. Can be grouped under a theme.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dseefeld @crummel @MichaelSimons