Skip to content

Enable (some?) cli bundled tools #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagood opened this issue Apr 13, 2018 · 5 comments
Closed

Enable (some?) cli bundled tools #428

dagood opened this issue Apr 13, 2018 · 5 comments
Labels
area-additional-repos Adding additional contributing repos

Comments

@dagood
Copy link
Member

dagood commented Apr 13, 2018

Bundled tool skip added in #418. I'm not sure how many bundled tools are skipped due to this:

<!--
Disable bundled tools until we can figure out:
Unable to find package dotnet-dev-certs.
Unable to find package dotnet-ef.
Unable to find package dotnet-sql-cache.
Unable to find package dotnet-user-secrets.
Unable to find package dotnet-watch.
-->
<EnvironmentVariables Include="CLIBUILD_SKIP_BUNDLEDDOTNETTOOLS=true" />

The intention is to skip any that aren't built from source, but I don't know if there are some being skipped that don't need to be.

/cc @dleeapho @dseefeld @peterhuene

@peterhuene
Copy link

peterhuene commented Apr 13, 2018

I think the plan was to skip these for source-build anyway since they aren't yet source-buildable. Users of source-built will need to manually install them as global tools and the CLI is going to "include-list" these commands to inform users they need to install them.

@dagood
Copy link
Member Author

dagood commented Apr 13, 2018

That sounds right to me. My concern is that there might be some bundled tools that are already source-buildable which are skipped because of the flag. I just noticed that these 5 are the only tools mentioned in BundledDotnetTools.props though, so it's probably fine.

@dseefeld dseefeld added triaged area-additional-repos Adding additional contributing repos labels Aug 20, 2018
@omajid
Copy link
Member

omajid commented Feb 3, 2020

I think we can close this. This is fixed in 3.1, right?

@dagood
Copy link
Member Author

dagood commented Feb 6, 2020

@dseefeld @crummel @adaggarwal, can you confirm this was fixed in 3.1 (that the tools are now included) and close?

@MichaelSimons
Copy link
Member

Closing as all bundled tools that the MSFT build does - dev-certs, format, user-jwts, user-secrets, and watch.

@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-additional-repos Adding additional contributing repos
Projects
Archived in project
Development

No branches or pull requests

5 participants