Skip to content

[CLI] review exit codes sent via New3CommandResult enum #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vlada-shubina opened this issue May 19, 2021 · 3 comments · Fixed by #4787
Closed

[CLI] review exit codes sent via New3CommandResult enum #3186

vlada-shubina opened this issue May 19, 2021 · 3 comments · Fixed by #4787
Assignees
Labels
area: refactoring The technical improvement/refactoring triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone

Comments

@vlada-shubina
Copy link
Member

Since a while we were using CreationResultStatus as the exit code, which was limited only to errors on template creation. Now we have different enum: New3CommandResult which we can modify and add new statuses.

  • review existing exit codes and create new codes where needed
  • review sending hex as exit code - it is not supported in Unix, where exit code is limited to 8-bit integer.
@bekir-ozturk bekir-ozturk added this to the Backlog milestone May 24, 2021
@bekir-ozturk bekir-ozturk added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label May 24, 2021
@vlada-shubina vlada-shubina added the area: refactoring The technical improvement/refactoring label Oct 25, 2021
@vlada-shubina vlada-shubina added the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Jan 18, 2022
@vlada-shubina
Copy link
Member Author

@baronfel let's discuss this issue at one of the next meetings, particularly using hex COM codes.

We recently got #4253 on one of the code being incorrect, however it's might be a good time to change others at the same time / release.

@baronfel
Copy link
Member

We should move to portable exit codes and document it as a breaking change for .NET 7.

@vlada-shubina vlada-shubina removed the need-pm-discussion Need agreement from PM that the issue aligns to targeted stories for any of the next 2 releases label Mar 11, 2022
@JanKrivanek JanKrivanek modified the milestones: Backlog, April 2022 Apr 4, 2022
@JanKrivanek JanKrivanek self-assigned this Apr 4, 2022
@vlada-shubina vlada-shubina modified the milestones: April 2022, May 2022 May 4, 2022
This was referenced May 23, 2022
@JanKrivanek
Copy link
Member

JanKrivanek commented May 30, 2022

Repositories to be touched:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: refactoring The technical improvement/refactoring triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants