Skip to content

Commit 59a439f

Browse files
committed
Fix: check failed reqs to retry only for positive limit
1 parent 351a3ad commit 59a439f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

kafka/producer/base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,11 @@ def _send_upstream(queue, client, codec, batch_time, batch_size,
9090
failed_reqs = ex.args[0]
9191
log.exception("Failed payloads count %s" % len(failed_reqs))
9292

93+
# if no limit, retry all failed messages until success
9394
if retries_limit is None:
94-
# retry all failed messages until success
9595
reqs_to_retry = failed_reqs
96-
elif not retries_limit < 0:
97-
#
96+
# makes sense to check failed reqs only if we have a limit > 0
97+
elif retries_limit > 0:
9898
for req in failed_reqs:
9999
if retries_limit and req.retries < retries_limit:
100100
updated_req = req._replace(retries=req.retries+1)

0 commit comments

Comments
 (0)