Skip to content

Commit e2e3054

Browse files
committed
413-Remove NavigationBarApp registration to check duplication
In react dev tool, there are duplicated providers. Seems like url changes does not represent redux connected component render. This fixed shakacode#413 issue but got an another error.
1 parent ff74e05 commit e2e3054

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

client/app/bundles/comments/components/NavigationBar/NavigationBar.jsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@ const NavigationBar = (props) => {
3232
</div>
3333
<div className="collapse navbar-collapse" id="bs-example-navbar-collapse-1">
3434
<ul className="nav navbar-nav">
35-
<li className={classNames(
36-
{ active: (pathname === paths.ROUTER_PATH || pathname === paths.REACT_ROUTER_PATH) },
37-
)}>
35+
<li className={classNames({ active: (pathname === paths.ROUTER_PATH) })}>
3836
<a href={paths.ROUTER_PATH}>React Router Demo</a>
3937
</li>
4038
<li className={classNames({ active: (pathname === paths.NO_ROUTER_PATH) })}>

client/app/bundles/comments/startup/clientRegistration.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import RouterApp from './ClientRouterApp';
1111
import SimpleCommentScreen from '../components/SimpleCommentScreen/SimpleCommentScreen';
1212
import routerCommentsStore from '../store/routerCommentsStore';
1313
import commentsStore from '../store/commentsStore';
14-
import NavigationBarApp from './NavigationBarApp';
14+
// import NavigationBarApp from './NavigationBarApp';
1515

1616
// Initizalize all locales for react-intl.
1717
addLocaleData([...en, ...de, ...ja, ...zh]);
@@ -23,7 +23,7 @@ ReactOnRails.setOptions({
2323
ReactOnRails.register({
2424
App,
2525
RouterApp,
26-
NavigationBarApp,
26+
// NavigationBarApp,
2727
SimpleCommentScreen,
2828
});
2929

0 commit comments

Comments
 (0)