[Macros] In-process plugin server library tied to compiler host, not target

PR swiftlang#73725 introduced the in-process plugin server library, but the
selection of the library depends on the selected toolchain, which
depends on the compiler target, not the host. When cross-compiling (for
example from macOS to a embedded Unix target), the compiler will
incorrectly chose the `.so` file, not find it, and fail to compile
things like the `@debugDescription` macro.

Move the in-process plugin server library code from the platform
toolchains into the parent type, and code it so it uses the right name
depending on the compiler host at compilation time. This discards the
target and only relies on the compiler host for selecting the right
library.

Author: drodriguez

include/swift/Driver/ToolChain.h

@@ -344,6 +344,10 @@ class ToolChain {
   virtual void addPluginArguments(const llvm::opt::ArgList &Args,
                                   llvm::opt::ArgStringList &Arguments) const {}
 
+  void addInProcPluginServerPath(const StringRef PluginPath,
+                                 const llvm::opt::ArgList &Args,
+                                 llvm::opt::ArgStringList &Arguments) const;
+
   /// Validates arguments passed to the toolchain.
   ///
   /// An override point for platform-specific subclasses to customize the

lib/Driver/DarwinToolChains.cpp

@@ -138,11 +138,7 @@ toolchains::Darwin::addPluginArguments(const ArgList &Args,
       programPath, /*shared=*/true, pluginPath);
 
   // In-process plugin server path.
-  auto inProcPluginServerPath = pluginPath;
-  llvm::sys::path::append(inProcPluginServerPath, "host",
-                          "libSwiftInProcPluginServer.dylib");
-  Arguments.push_back("-in-process-plugin-server-path");
-  Arguments.push_back(Args.MakeArgString(inProcPluginServerPath));
+  addInProcPluginServerPath(pluginPath, Args, Arguments);
 
   // Default plugin path.
   auto defaultPluginPath = pluginPath;

lib/Driver/ToolChains.cpp

@@ -1468,6 +1468,25 @@ void ToolChain::addLinkRuntimeLib(const ArgList &Args, ArgStringList &Arguments,
   Arguments.push_back(Args.MakeArgString(P));
 }
 
+void ToolChain::addInProcPluginServerPath(const StringRef PluginPath,
+                                          const llvm::opt::ArgList &Args,
+                                          llvm::opt::ArgStringList &Arguments) const {
+  SmallString<128> inProcPluginServerPath = PluginPath;
+  llvm::sys::path::append(inProcPluginServerPath, "host",
+#if defined(__APPLE__)
+                                "libSwiftInProcPluginServer.dylib"
+#elif defined(_WIN32)
+                                "SwiftInProcPluginServer.dll"
+#elif defined(__unix__)
+                                "libSwiftInProcPluginServer.so"
+#else
+#error Unknown compiler host
+#endif
+                                );
+  Arguments.push_back("-in-process-plugin-server-path");
+  Arguments.push_back(Args.MakeArgString(inProcPluginServerPath));
+}
+
 void ToolChain::getClangLibraryPath(const ArgList &Args,
                                     SmallString<128> &LibPath) const {
   const llvm::Triple &T = getTriple();

lib/Driver/UnixToolChains.cpp

@@ -59,11 +59,7 @@ toolchains::GenericUnix::addPluginArguments(const ArgList &Args,
       programPath, /*shared=*/true, pluginPath);
 
   // In-process plugin server path.
-  auto inProcPluginServerPath = pluginPath;
-  llvm::sys::path::append(inProcPluginServerPath, "host",
-                          "libSwiftInProcPluginServer.so");
-  Arguments.push_back("-in-process-plugin-server-path");
-  Arguments.push_back(Args.MakeArgString(inProcPluginServerPath));
+  addInProcPluginServerPath(pluginPath, Args, Arguments);
 
   // Default plugin path.
   auto defaultPluginPath = pluginPath;

lib/Driver/WindowsToolChains.cpp

@@ -51,11 +51,7 @@ toolchains::Windows::addPluginArguments(const ArgList &Args,
   llvm::sys::path::remove_filename(LibraryPath); // Remove `swift`
 
   // In-process plugin server path.
-  SmallString<261> InProcPluginServerPath = LibraryPath;
-  llvm::sys::path::append(InProcPluginServerPath,
-                          "SwiftInProcPluginServer.dll");
-  Arguments.push_back("-in-process-plugin-server-path");
-  Arguments.push_back(Args.MakeArgString(InProcPluginServerPath));
+  addInProcPluginServerPath(LibraryPath, Args, Arguments);
 
   // Default plugin path.
   Arguments.push_back("-plugin-path");