Skip to content

Commit 8232a90

Browse files
dwaynedwayne
committed
Add elm-review back to the project and fix any errors it finds
1 parent 03676ac commit 8232a90

File tree

10 files changed

+194
-44
lines changed

10 files changed

+194
-44
lines changed

‎bin/check

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ main () {
2929
run format --validate
3030
run test-elm
3131
run test-elm-main
32+
run review
3233

3334
display "Everything looks good!"
3435
}

‎devbox.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
"elmPackages.elm": "latest",
99
"elmPackages.elm-format": "latest",
1010
"elmPackages.elm-optimize-level-2": "latest",
11+
"elmPackages.elm-review": "latest",
1112
"elmPackages.elm-test": "latest",
1213
"shellcheck": "latest",
1314
"terser": "latest"
@@ -19,7 +20,7 @@
1920
},
2021
"shell": {
2122
"init_hook": [
22-
"[ -f $project/init.sh ] && . $project/init.sh"
23+
". $project/init.sh"
2324
]
2425
}
2526
}

‎devbox.lock

Lines changed: 80 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"lockfile_version": "1",
33
"packages": {
44
"caddy@latest": {
5-
"last_modified": "2025-03-11T17:52:14Z",
6-
"resolved": "github:NixOS/nixpkgs/0d534853a55b5d02a4ababa1d71921ce8f0aee4c#caddy",
5+
"last_modified": "2025-03-23T14:04:58Z",
6+
"resolved": "github:NixOS/nixpkgs/f3a2a0601e9669a6e38af25b46ce6c4563bcb6da#caddy",
77
"source": "devbox-search",
88
"version": "2.9.1",
99
"systems": {
@@ -21,11 +21,11 @@
2121
"outputs": [
2222
{
2323
"name": "out",
24-
"path": "/nix/store/8iw9sy9p5752fkghacf4gc32hskbiis8-caddy-2.9.1",
24+
"path": "/nix/store/ck57g3lwbzpdiwbjdaa6b896m7m6w31k-caddy-2.9.1",
2525
"default": true
2626
}
2727
],
28-
"store_path": "/nix/store/8iw9sy9p5752fkghacf4gc32hskbiis8-caddy-2.9.1"
28+
"store_path": "/nix/store/ck57g3lwbzpdiwbjdaa6b896m7m6w31k-caddy-2.9.1"
2929
},
3030
"x86_64-darwin": {
3131
"outputs": [
@@ -41,75 +41,75 @@
4141
"outputs": [
4242
{
4343
"name": "out",
44-
"path": "/nix/store/d3pfmfj3syab6fqf3y707ap5x8akq6jq-caddy-2.9.1",
44+
"path": "/nix/store/vdjnfdjnnqspc67fjys692b4hishmljd-caddy-2.9.1",
4545
"default": true
4646
}
4747
],
48-
"store_path": "/nix/store/d3pfmfj3syab6fqf3y707ap5x8akq6jq-caddy-2.9.1"
48+
"store_path": "/nix/store/vdjnfdjnnqspc67fjys692b4hishmljd-caddy-2.9.1"
4949
}
5050
}
5151
},
5252
"dart-sass@latest": {
53-
"last_modified": "2025-03-11T17:52:14Z",
54-
"resolved": "github:NixOS/nixpkgs/0d534853a55b5d02a4ababa1d71921ce8f0aee4c#dart-sass",
53+
"last_modified": "2025-03-26T18:47:43Z",
54+
"resolved": "github:NixOS/nixpkgs/bd3bac8bfb542dbde7ffffb6987a1a1f9d41699f#dart-sass",
5555
"source": "devbox-search",
56-
"version": "1.85.1",
56+
"version": "1.86.0",
5757
"systems": {
5858
"aarch64-darwin": {
5959
"outputs": [
6060
{
6161
"name": "out",
62-
"path": "/nix/store/mailx4bcn1my3dp80q6imysn9zchd0vq-dart-sass-1.85.1",
62+
"path": "/nix/store/jicxqpjhnl8naq9p3j5yv3nxznm6ca0p-dart-sass-1.86.0",
6363
"default": true
6464
},
6565
{
6666
"name": "pubcache",
67-
"path": "/nix/store/8hqlng0spzrbhkvi8ckcvs44npi1qydw-dart-sass-1.85.1-pubcache"
67+
"path": "/nix/store/nmcfyzsxbmcimabw9bc1q38rjvrbang4-dart-sass-1.86.0-pubcache"
6868
}
6969
],
70-
"store_path": "/nix/store/mailx4bcn1my3dp80q6imysn9zchd0vq-dart-sass-1.85.1"
70+
"store_path": "/nix/store/jicxqpjhnl8naq9p3j5yv3nxznm6ca0p-dart-sass-1.86.0"
7171
},
7272
"aarch64-linux": {
7373
"outputs": [
7474
{
7575
"name": "out",
76-
"path": "/nix/store/sx8im4w5pw5k5s6kzjdp04npc1w4yj4a-dart-sass-1.85.1",
76+
"path": "/nix/store/1n001lchf1llac3v8whldjjzw3cav87h-dart-sass-1.86.0",
7777
"default": true
7878
},
7979
{
8080
"name": "pubcache",
81-
"path": "/nix/store/wyafgs19g16qy6mabskzlnk8a7rjcllk-dart-sass-1.85.1-pubcache"
81+
"path": "/nix/store/naf1mym2xf3v9gnck3m0pngd3w0ylvbk-dart-sass-1.86.0-pubcache"
8282
}
8383
],
84-
"store_path": "/nix/store/sx8im4w5pw5k5s6kzjdp04npc1w4yj4a-dart-sass-1.85.1"
84+
"store_path": "/nix/store/1n001lchf1llac3v8whldjjzw3cav87h-dart-sass-1.86.0"
8585
},
8686
"x86_64-darwin": {
8787
"outputs": [
8888
{
8989
"name": "out",
90-
"path": "/nix/store/lq5xc9rp2vm40x3b1qwffirp2b64kbaa-dart-sass-1.85.1",
90+
"path": "/nix/store/8sy639nfmbws12qm6lvqfpy0nplpbqsd-dart-sass-1.86.0",
9191
"default": true
9292
},
9393
{
9494
"name": "pubcache",
95-
"path": "/nix/store/c7axbbkvzf9aaa82cywg6phf5zjdkmi6-dart-sass-1.85.1-pubcache"
95+
"path": "/nix/store/dw1k4sb58gp8bq1xlyfz6w96msyf03pb-dart-sass-1.86.0-pubcache"
9696
}
9797
],
98-
"store_path": "/nix/store/lq5xc9rp2vm40x3b1qwffirp2b64kbaa-dart-sass-1.85.1"
98+
"store_path": "/nix/store/8sy639nfmbws12qm6lvqfpy0nplpbqsd-dart-sass-1.86.0"
9999
},
100100
"x86_64-linux": {
101101
"outputs": [
102102
{
103103
"name": "out",
104-
"path": "/nix/store/hyqwj3jvzf2hmhgjrrccd787cifkyprl-dart-sass-1.85.1",
104+
"path": "/nix/store/ksid7wkg0wi3m36a8md02qnpdk4myjg3-dart-sass-1.86.0",
105105
"default": true
106106
},
107107
{
108108
"name": "pubcache",
109-
"path": "/nix/store/r2zw4p5awgjqq8lkc290ll39vyl0b8ar-dart-sass-1.85.1-pubcache"
109+
"path": "/nix/store/azrk511qrg0vyh322kz2d07a9i3w4ifs-dart-sass-1.86.0-pubcache"
110110
}
111111
],
112-
"store_path": "/nix/store/hyqwj3jvzf2hmhgjrrccd787cifkyprl-dart-sass-1.85.1"
112+
"store_path": "/nix/store/ksid7wkg0wi3m36a8md02qnpdk4myjg3-dart-sass-1.86.0"
113113
}
114114
}
115115
},
@@ -123,31 +123,31 @@
123123
"outputs": [
124124
{
125125
"name": "out",
126-
"path": "/nix/store/dy5wyikk7sgsb58qfm7f3sxdrnsmm4v3-elm-format-0.8.7",
126+
"path": "/nix/store/4p502wy4cgjwpkpj0pl3jdpmxrhn6j2c-elm-format-0.8.7",
127127
"default": true
128128
}
129129
],
130-
"store_path": "/nix/store/dy5wyikk7sgsb58qfm7f3sxdrnsmm4v3-elm-format-0.8.7"
130+
"store_path": "/nix/store/4p502wy4cgjwpkpj0pl3jdpmxrhn6j2c-elm-format-0.8.7"
131131
},
132132
"aarch64-linux": {
133133
"outputs": [
134134
{
135135
"name": "out",
136-
"path": "/nix/store/5is2gkla1f4a2yfqlwg01was85afizav-elm-format-0.8.7",
136+
"path": "/nix/store/hlhdz8klahxypf8pqzsm5nwr3xjfkm3m-elm-format-0.8.7",
137137
"default": true
138138
}
139139
],
140-
"store_path": "/nix/store/5is2gkla1f4a2yfqlwg01was85afizav-elm-format-0.8.7"
140+
"store_path": "/nix/store/hlhdz8klahxypf8pqzsm5nwr3xjfkm3m-elm-format-0.8.7"
141141
},
142142
"x86_64-darwin": {
143143
"outputs": [
144144
{
145145
"name": "out",
146-
"path": "/nix/store/1x48vz1lfaqlq3839q7gkq62wwg5yvy3-elm-format-0.8.7",
146+
"path": "/nix/store/3q59w273akmyj5fq5cjly3k83m3dw62b-elm-format-0.8.7",
147147
"default": true
148148
}
149149
],
150-
"store_path": "/nix/store/1x48vz1lfaqlq3839q7gkq62wwg5yvy3-elm-format-0.8.7"
150+
"store_path": "/nix/store/3q59w273akmyj5fq5cjly3k83m3dw62b-elm-format-0.8.7"
151151
},
152152
"x86_64-linux": {
153153
"outputs": [
@@ -209,6 +209,54 @@
209209
}
210210
}
211211
},
212+
"elmPackages.elm-review@latest": {
213+
"last_modified": "2025-03-11T17:52:14Z",
214+
"resolved": "github:NixOS/nixpkgs/0d534853a55b5d02a4ababa1d71921ce8f0aee4c#elmPackages.elm-review",
215+
"source": "devbox-search",
216+
"version": "2.13.2",
217+
"systems": {
218+
"aarch64-darwin": {
219+
"outputs": [
220+
{
221+
"name": "out",
222+
"path": "/nix/store/km4m7yziy3qgjy4j27ahak4v2bd65zxp-elm-review-2.13.2",
223+
"default": true
224+
}
225+
],
226+
"store_path": "/nix/store/km4m7yziy3qgjy4j27ahak4v2bd65zxp-elm-review-2.13.2"
227+
},
228+
"aarch64-linux": {
229+
"outputs": [
230+
{
231+
"name": "out",
232+
"path": "/nix/store/7zwnn05ilia2aw5ln8hhf3ca495n602j-elm-review-2.13.2",
233+
"default": true
234+
}
235+
],
236+
"store_path": "/nix/store/7zwnn05ilia2aw5ln8hhf3ca495n602j-elm-review-2.13.2"
237+
},
238+
"x86_64-darwin": {
239+
"outputs": [
240+
{
241+
"name": "out",
242+
"path": "/nix/store/y1ad82rjq14z6y73akpb03kbqsamy82k-elm-review-2.13.2",
243+
"default": true
244+
}
245+
],
246+
"store_path": "/nix/store/y1ad82rjq14z6y73akpb03kbqsamy82k-elm-review-2.13.2"
247+
},
248+
"x86_64-linux": {
249+
"outputs": [
250+
{
251+
"name": "out",
252+
"path": "/nix/store/rz8cz4p4zsa3rwhqlxiz85pk43k3nmwy-elm-review-2.13.2",
253+
"default": true
254+
}
255+
],
256+
"store_path": "/nix/store/rz8cz4p4zsa3rwhqlxiz85pk43k3nmwy-elm-review-2.13.2"
257+
}
258+
}
259+
},
212260
"elmPackages.elm-test@latest": {
213261
"last_modified": "2025-03-16T16:17:41Z",
214262
"resolved": "github:NixOS/nixpkgs/8f76cf16b17c51ae0cc8e55488069593f6dab645#elmPackages.elm-test",
@@ -239,11 +287,11 @@
239287
"outputs": [
240288
{
241289
"name": "out",
242-
"path": "/nix/store/4374ln9kv2a1vzjrgggikkvvrr4m7cdl-elm-test-0.19.1-revision15",
290+
"path": "/nix/store/pb0s8bfmah4vq31nyxc0cz9ggjay4ynx-elm-test-0.19.1-revision15",
243291
"default": true
244292
}
245293
],
246-
"store_path": "/nix/store/4374ln9kv2a1vzjrgggikkvvrr4m7cdl-elm-test-0.19.1-revision15"
294+
"store_path": "/nix/store/pb0s8bfmah4vq31nyxc0cz9ggjay4ynx-elm-test-0.19.1-revision15"
247295
},
248296
"x86_64-linux": {
249297
"outputs": [
@@ -295,15 +343,15 @@
295343
"outputs": [
296344
{
297345
"name": "out",
298-
"path": "/nix/store/bz66yy4snqzsfh03i04qyp4dylpkdnl8-elm-0.19.1",
346+
"path": "/nix/store/xk273xvnb202ggf3aaqrqyvglj1pv4qs-elm-0.19.1",
299347
"default": true
300348
},
301349
{
302350
"name": "doc",
303-
"path": "/nix/store/x97vrm8vhf5j2wgl8x54h46f6psp1h6i-elm-0.19.1-doc"
351+
"path": "/nix/store/8sbmdli40gpc41d4g1x8gkl5hhmr8155-elm-0.19.1-doc"
304352
}
305353
],
306-
"store_path": "/nix/store/bz66yy4snqzsfh03i04qyp4dylpkdnl8-elm-0.19.1"
354+
"store_path": "/nix/store/xk273xvnb202ggf3aaqrqyvglj1pv4qs-elm-0.19.1"
307355
},
308356
"x86_64-linux": {
309357
"outputs": [

‎init.sh

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ check-scripts () {
3232
}
3333

3434
format () {
35-
cd "$project" && elm-format src tests "${@:---yes}"
35+
cd "$project" && elm-format review/src src tests "${@:---yes}"
3636
}
3737

3838
test-elm () {
@@ -43,6 +43,10 @@ test-elm-main () {
4343
test-elm make src/Main.elm
4444
}
4545

46+
review () {
47+
cd "$project" && elm-review review/src src tests
48+
}
49+
4650
build-development () {
4751
build "$build_development"
4852
}
@@ -69,7 +73,7 @@ deploy-production () {
6973

7074
export -f \
7175
clean \
72-
check-scripts format test-elm test-elm-main \
76+
check-scripts format test-elm test-elm-main review \
7377
build-development build-production \
7478
serve-prototype serve-development serve-production \
7579
deploy-production
@@ -81,6 +85,7 @@ export -f \
8185
alias c=check
8286
alias f=format
8387
alias t=test-elm
88+
alias r=review
8489
alias b=build-development
8590
alias bp=build-prototype
8691
alias s=serve-development

‎review/elm.json

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
{
2+
"type": "application",
3+
"source-directories": [
4+
"src"
5+
],
6+
"elm-version": "0.19.1",
7+
"dependencies": {
8+
"direct": {
9+
"elm/core": "1.0.5",
10+
"elm/json": "1.1.3",
11+
"elm/project-metadata-utils": "1.0.2",
12+
"jfmengels/elm-review": "2.15.1",
13+
"jfmengels/elm-review-code-style": "1.2.0",
14+
"jfmengels/elm-review-common": "1.3.3",
15+
"jfmengels/elm-review-debug": "1.0.8",
16+
"jfmengels/elm-review-documentation": "2.0.4",
17+
"jfmengels/elm-review-simplify": "2.1.6",
18+
"jfmengels/elm-review-unused": "1.2.4",
19+
"stil4m/elm-syntax": "7.3.8"
20+
},
21+
"indirect": {
22+
"elm/bytes": "1.0.8",
23+
"elm/html": "1.0.0",
24+
"elm/parser": "1.1.0",
25+
"elm/random": "1.0.0",
26+
"elm/regex": "1.0.0",
27+
"elm/time": "1.0.0",
28+
"elm/virtual-dom": "1.0.3",
29+
"elm-explorations/test": "2.2.0",
30+
"pzp1997/assoc-list": "1.0.0",
31+
"rtfeldman/elm-hex": "1.0.0",
32+
"stil4m/structured-writer": "1.0.3"
33+
}
34+
},
35+
"test-dependencies": {
36+
"direct": {
37+
"elm-explorations/test": "2.2.0"
38+
},
39+
"indirect": {}
40+
}
41+
}

0 commit comments

Comments
 (0)