Skip to content

Are you actually maintaining this repo?? #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lcervo opened this issue Nov 13, 2022 · 1 comment
Closed

Are you actually maintaining this repo?? #2049

lcervo opened this issue Nov 13, 2022 · 1 comment
Labels

Comments

@lcervo
Copy link

lcervo commented Nov 13, 2022

Describe the bug

The angular code is all over the place. It doesn't compile, it has A LOT of lint and logic errors. It's like it has been written by a bunch of junior devs with no clues what they are doing.

Do you have plans to make it work and support it?

Expected behavior

the angular project (including the material one) should at least compile.

Steps to reproduce the issue

just open the repo with your IDE of choice and compile the angular project(s)

Screenshots

No response

In which browser are you experiencing the issue?

it doesn't matter

Which Version of JSON Forms are you using?

xxx

Framework

Angular

RendererSet

Material

Additional context

No response

@sdirix
Copy link
Member

sdirix commented Nov 13, 2022

Hi @lcervo,

Are you actually maintaining this repo??

The answer is: Yes

Thanks for the feedback. As this is an open source project, feel free to contribute improvements where you feel the project is lacking. If you want to make sure your contributions can be merged, I would like to recommend open concrete issues describing the problem and suggestions on how to fix them. If these fit into the ongoing development of the framework we'll happily review your contributions and merge if they meet our quality standards.

It seems that you are struggling setting up the development environment on your machine. Please make sure that you followed our short development guide in the root Readme, especially the First time setup and the build/testing scripts. If there are issues related to your environment you might want to try the VS Code dev container setup instead. You can also check the typical flow of a build in our automated builds which run on every PR and merge to master. These run successfully.

As the main question of this issue is answered I'll close it for now. Feel free to comment if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants