Skip to content

i18n Support #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koegel opened this issue Feb 9, 2017 · 8 comments
Closed

i18n Support #496

koegel opened this issue Feb 9, 2017 · 8 comments
Milestone

Comments

@koegel
Copy link
Member

koegel commented Feb 9, 2017

JSON Forms must support i18n for labels of properties (shown in controls) and labels in categories and groups. Furthermore we need to examine all UI schema elements if they contain strings that are to be shown in the form and also support i18n for them.
i18n must be aligned with EMF Forms support to enable a smooth integration.

@koegel koegel added this to the Backlog milestone Feb 9, 2017
@eneufeld
Copy link
Member

Also for validation messages

@edgarmueller
Copy link
Contributor

edgarmueller commented Dec 14, 2017

For translating string based on the schema/UI schema we should have a look at react-redux-i18n (we do not necessarily need to use as it has an additional dependency on react-i18nify).

For dates and numbers, look at the Intl doc.

@edgarmueller
Copy link
Contributor

This should be reviewed. Actual changes might also follow later.

@edgarmueller edgarmueller modified the milestones: 2.1.0, next Apr 3, 2018
@edgarmueller edgarmueller removed the lab label Apr 3, 2018
@edgarmueller
Copy link
Contributor

I had a look at the current state of the i18n support and I would suggest to do the following:

  • for the time being, drop support for number formatting as it takes too much effort to implement
  • remove transformProps reducer (since functions should not be part of the state) and replace i18n with custom middleware, which would intercept the INIT action and transform the uischema for translating any labels and descriptions

This approach is cleaner and redux-idiomatic.

@edgarmueller edgarmueller modified the milestones: next, 2.1.0 Apr 6, 2018
@edgarmueller edgarmueller modified the milestones: 2.1.0, Backlog Jun 28, 2018
@eneufeld
Copy link
Member

@edgarmueller didn't we fixed this by now?

@edgarmueller
Copy link
Contributor

Yes, I think we can close it for now.

@ksze
Copy link

ksze commented May 5, 2021

How does i18n work? Where is it documented?

@sdirix
Copy link
Member

sdirix commented May 21, 2021

How does i18n work? Where is it documented?

Hi @ksze. This issue is quite old, see this issue for a short description of the current mechanism and how we intend to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants