Transpile coffeescript written in ES6 #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyerburgh
reviewed
Dec 11, 2017
lib/compilers/coffee-compiler.js
Outdated
| sourceMap: true | ||
| sourceMap: true, | ||
| transpile: { | ||
| presets: ['env'] |
There was a problem hiding this comment.
Would we want to use presets that the user has in their babelrc?
There was a problem hiding this comment.
@eddyerburgh Yes, actually that should be better
|
@eddyerburgh Thanks for reviewing the previous commit. These changes should allow users to use their .babelrc |
eddyerburgh
requested changes
Dec 12, 2017
|
@eddyerburgh Here ^ some tests added. Please review it. Pleasure to contribute to this project :) |
eddyerburgh
approved these changes
Dec 13, 2017
|
Thanks @wataruoguchi 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coffeescriptcan adopt babel as a transpiler.transpileis the way how they set transpiler.Please see http://coffeescript.org/#transpilation
This allows you to have vue files which adopt coffee/coffeescript (ES6) as
lang.I added tests and vue files.