Skip to content

feat(sourceMap): Make source-mapping of multi-files component working… #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

csailly
Copy link
Contributor

@csailly csailly commented Dec 13, 2017

PR for issue #36 Code coverage doesn't work on files linked with "src="

@eddyerburgh
Copy link
Member

This is awesome, thanks so much 🙂

@eddyerburgh eddyerburgh merged commit 213ac68 into vuejs:master Dec 13, 2017
@Toilal
Copy link
Contributor

Toilal commented Dec 19, 2017

It still doesn't work with lang="ts" (TypeScript)

@dinvlad
Copy link

dinvlad commented Feb 19, 2018

Hmm, it works if I set

<script lang="ts">
  export { default } from './component';
</script>

but not if I use

<script src="./component.ts"></script>

Could this be improved to include the second use case?

@eddyerburgh
Copy link
Member

@dinvlad could you please open an issue. Then I can keep track of the bug and look into fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants