Skip to content

Commit 7e59e72

Browse files
committed
Disable test coverage
It wasn't used and it prevents tests from being cached. See golang/go#23565 for more details.
1 parent 05d9871 commit 7e59e72

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

Makefile

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ git_commit := $(shell git describe --dirty --always)
44
version_pkg := github.com/weaveworks/eksctl/pkg/version
55

66
# The dependencies version should be bumped every time the build dependencies are updated
7-
EKSCTL_DEPENDENCIES_IMAGE ?= weaveworks/eksctl-build:deps-0.3
7+
EKSCTL_DEPENDENCIES_IMAGE ?= weaveworks/eksctl-build:deps-0.4
88
EKSCTL_BUILDER_IMAGE ?= weaveworks/eksctl-builder:latest
99
EKSCTL_IMAGE ?= weaveworks/eksctl:latest
1010

@@ -54,16 +54,15 @@ test: ## Run unit test (and re-generate code under test)
5454
$(MAKE) lint
5555
$(MAKE) generate-aws-mocks-test generate-bindata-assets-test generate-kubernetes-types-test
5656
$(MAKE) unit-test
57-
test -z $(COVERALLS_TOKEN) || time "$(GOBIN)/goveralls" -coverprofile=coverage.out -service=circle-ci
5857
$(MAKE) build-integration-test
5958

6059
.PHONY: unit-test
6160
unit-test: ## Run unit test only
62-
CGO_ENABLED=0 time go test -covermode=count -coverprofile=coverage.out ./pkg/... ./cmd/... $(UNIT_TEST_ARGS)
61+
CGO_ENABLED=0 time go test ./pkg/... ./cmd/... $(UNIT_TEST_ARGS)
6362

6463
.PHONY: unit-test-race
6564
unit-test-race: ## Run unit test with race detection
66-
CGO_ENABLED=1 time go test -race -covermode=atomic -coverprofile=coverage.out ./pkg/... ./cmd/... $(UNIT_TEST_ARGS)
65+
CGO_ENABLED=1 time go test -race ./pkg/... ./cmd/... $(UNIT_TEST_ARGS)
6766

6867
.PHONY: build-integration-test
6968
build-integration-test: ## Build integration test binary

install-build-deps.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ fi
1616
go install github.com/jteeuwen/go-bindata/go-bindata
1717
go install github.com/weaveworks/github-release
1818
go install golang.org/x/tools/cmd/stringer
19-
go install github.com/mattn/goveralls
2019
go install github.com/vektra/mockery/cmd/mockery
2120

2221

tools.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
_ "github.com/goreleaser/goreleaser"
1818
_ "github.com/jteeuwen/go-bindata/go-bindata"
1919
_ "github.com/kubernetes-sigs/aws-iam-authenticator/cmd/aws-iam-authenticator"
20-
_ "github.com/mattn/goveralls"
2120
_ "github.com/vektra/mockery/cmd/mockery"
2221
_ "github.com/weaveworks/github-release"
2322
_ "golang.org/x/tools/cmd/stringer"

0 commit comments

Comments
 (0)