-
Notifications
You must be signed in to change notification settings - Fork 31
Add Smoke Testing to the CI pipeline #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We might want to take some inspiration from https://github.com/cyrille-leclerc/my-serverless-shopping-cart/tree/main/checkout-function/deploy, which uses https://registry.terraform.io/modules/terraform-aws-modules/lambda/aws/latest |
@cachedout would someone from your team be able to help out with the CI setup for the newly added smoke tests once #296 is finalized)? |
Reopening this - we can close it once the CI integration has been done. |
@simitt Apologies, this one slipped through my filters. It looks like this has been done by @kruskall in #310 and that it's currently under review. Is there anything needed beyond that? |
Nothing more to do here. |
Following the deployment of a broken release (v1.0.1), it has been suggested to introduce smoke testing to the repository. These smoke tests would take inspiration from elastic-lambda-extension-testing and would be implemented via Terraform. A possible process outline would be as follows:
An implementation of SAM CLI-based E2E testing already exists, but since the SAM CLI does not support the Lambda Logs API used for Metrics, its relevance will decrease by the time we release
v1.1
.The text was updated successfully, but these errors were encountered: