Skip to content

Add Smoke Testing to the CI pipeline #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlvoiseux opened this issue Jun 9, 2022 · 5 comments · Fixed by #296
Closed

Add Smoke Testing to the CI pipeline #217

jlvoiseux opened this issue Jun 9, 2022 · 5 comments · Fixed by #296
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jlvoiseux
Copy link
Contributor

Following the deployment of a broken release (v1.0.1), it has been suggested to introduce smoke testing to the repository. These smoke tests would take inspiration from elastic-lambda-extension-testing and would be implemented via Terraform. A possible process outline would be as follows:

  • Build the Lambda layer
  • Spin up an APM-instrumented Lambda function behind an API Gateway
  • Attach the extension layer to the function
  • Perform 2 invocations (in order to also check metrics generation)
  • Check a dedicated ES instance for the presence of target documents

An implementation of SAM CLI-based E2E testing already exists, but since the SAM CLI does not support the Lambda Logs API used for Metrics, its relevance will decrease by the time we release v1.1.

@jlvoiseux jlvoiseux added enhancement New feature or request aws-λ-extension AWS Lambda Extension labels Jun 9, 2022
@simitt simitt added this to the 8.5 milestone Jul 26, 2022
@simitt simitt removed aws-λ-extension AWS Lambda Extension 8.5-candidate labels Jul 29, 2022
@axw
Copy link
Member

axw commented Aug 18, 2022

@simitt
Copy link
Contributor

simitt commented Aug 30, 2022

@cachedout would someone from your team be able to help out with the CI setup for the newly added smoke tests once #296 is finalized)?

@axw
Copy link
Member

axw commented Sep 15, 2022

Reopening this - we can close it once the CI integration has been done.

@cachedout
Copy link

@cachedout would someone from your team be able to help out with the CI setup for the newly added smoke tests once #296 is finalized)?

@simitt Apologies, this one slipped through my filters. It looks like this has been done by @kruskall in #310 and that it's currently under review. Is there anything needed beyond that?

@simitt
Copy link
Contributor

simitt commented Sep 27, 2022

Nothing more to do here.

@simitt simitt closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants