Skip to content

Refactor ImageBlock URL handling and file resolution logic. #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented May 6, 2025

Streamline URL updates and file resolution by leveraging DiagnosticLinkInlineParser. This reduces redundancy and ensures consistent handling of relative URLs. Improved error messaging for nonexistent files.

Fixes #1134

image

Streamline URL updates and file resolution by leveraging `DiagnosticLinkInlineParser`. This reduces redundancy and ensures consistent handling of relative URLs. Improved error messaging for nonexistent files.

Fixes #1134
@Mpdreamz Mpdreamz requested a review from a team as a code owner May 6, 2025 15:57
@Mpdreamz Mpdreamz added the fix label May 6, 2025
@Mpdreamz Mpdreamz self-assigned this May 6, 2025
Copy link
Contributor

@cotti cotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mpdreamz Mpdreamz merged commit 5bae611 into main May 6, 2025
14 checks passed
@Mpdreamz Mpdreamz deleted the fix/image-block-url-resolving branch May 6, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems linking to images
2 participants