Merge 59b5269 into 2702523

Author: Henry Wong

go/packages/golist.go

@@ -240,6 +240,13 @@ func addNeededOverlayPackages(cfg *Config, driver driver, response *responseDedu
 }
 
 func runContainsQueries(cfg *Config, driver driver, response *responseDeduper, queries []string, rootDirs func() map[string]string) error {
+	go111ModuleOff := false
+	for i := range cfg.Env {
+		if cfg.Env[len(cfg.Env)-i-1] == "GO111MODULE=off" {
+			go111ModuleOff = true
+			break
+		}
+	}
 	for _, query := range queries {
 		// TODO(matloob): Do only one query per directory.
 		fdir := filepath.Dir(query)
@@ -249,6 +256,14 @@ func runContainsQueries(cfg *Config, driver driver, response *responseDeduper, q
 		if err != nil {
 			return fmt.Errorf("could not determine absolute path of file= query path %q: %v", query, err)
 		}
+		if go111ModuleOff {
+			// Given that langserver converts the repos to modules explicitly, 'go list' has no idea where to find the
+			// packages with 'GO111MODULE=off'. Setting the list pattern to relative local import will guide 'go list'
+			// to find the part of the packages inside current repo.
+			if dir, err := filepath.Rel(cfg.Dir, fdir); err == nil {
+				pattern = "." + string(filepath.Separator) + dir
+			}
+		}
 		dirResponse, err := driver(cfg, pattern)
 		if err != nil || (len(dirResponse.Packages) == 1 && len(dirResponse.Packages[0].Errors) == 1) {
 			// There was an error loading the package. Try to load the file as an ad-hoc package.

internal/lsp/cache/session.go

@@ -93,6 +93,12 @@ func (s *session) NewView(ctx context.Context, name string, folder span.URI) sou
 		},
 		ignoredURIs: make(map[span.URI]struct{}),
 	}
+
+	// Setting 'GO111MODULE=off' by default. 'GO111MODULE=off' is inconsistent with module mode, this will disable
+	// the deps download.
+	// TODO(henrywong) Use 'GOPROXY=off' to disable the network access
+	v.env = append(v.env, "GO111MODULE=off")
+
 	// Preemptively build the builtin package,
 	// so we immediately add builtin.go to the list of ignored files.
 	v.buildBuiltinPkg(ctx)

internal/lsp/elasticserver.go

@@ -189,10 +189,8 @@ type WorkspaceFolderMeta struct {
 // manageDeps will try its best to convert the folders to modules. The core functions, like deps downloading and deps
 // management, will be implemented in the package 'cache'.
 func (s ElasticServer) ManageDeps(folders *[]protocol.WorkspaceFolder) error {
-	// Note: For the upstream go langserver, granularity of the workspace folders is repository. But for the elastic go
-	// language server, there are repositories contain multiple modules. In order to handle the modules separately, we
-	// consider different modules as different workspace folders, so we can manage the dependency of different modules
-	// separately.
+	// In order to handle the modules separately, we consider different modules as different workspace folders, so we
+	// can manage the dependency of different modules separately.
 	for _, folder := range *folders {
 		metadata := &WorkspaceFolderMeta{}
 		if folder.URI != "" {

internal/lsp/general.go

@@ -38,6 +38,9 @@ func (s *Server) initialize(ctx context.Context, params *protocol.InitializePara
 		if opt, ok := opts["noIncrementalSync"].(bool); ok && opt {
 			s.textDocumentSyncKind = protocol.Full
 		}
+		if opt, ok := opts["installGoDependency"].(bool); ok && opt {
+			s.installGoDependency = true
+		}
 	}
 
 	// Default to using synopsis as a default for hover information.

internal/lsp/server.go

@@ -88,6 +88,7 @@ type Server struct {
 	preferredContentFormat        protocol.MarkupKind
 	disabledAnalyses              map[string]struct{}
 	wantSuggestedFixes            bool
+	installGoDependency           bool
 
 	supportedCodeActions map[source.FileKind]map[protocol.CodeActionKind]bool
 

internal/lsp/workspace.go

@@ -8,8 +8,10 @@ import (
 	"context"
 
 	"golang.org/x/tools/internal/lsp/protocol"
+	"golang.org/x/tools/internal/lsp/telemetry/log"
 	"golang.org/x/tools/internal/span"
 	errors "golang.org/x/xerrors"
+	"os/exec"
 )
 
 func (s *Server) changeFolders(ctx context.Context, event protocol.WorkspaceFoldersChangeEvent) error {
@@ -31,6 +33,13 @@ func (s *Server) changeFolders(ctx context.Context, event protocol.WorkspaceFold
 }
 
 func (s *Server) addView(ctx context.Context, name string, uri span.URI) error {
+	if s.installGoDependency {
+		cmd := exec.Command("go", "mod", "download")
+		cmd.Dir = uri.Filename()
+		if err := cmd.Run(); err != nil {
+			log.Error(ctx, "failed to download the dependencies", err)
+		}
+	}
 	view := s.session.NewView(ctx, name, uri)
 	s.stateMu.Lock()
 	state := s.state