Skip to content

Commit 9bd811f

Browse files
committed
Remove redundant promise rejection callback
nodejs/node#34387
1 parent b3007c9 commit 9bd811f

File tree

3 files changed

+2
-53
lines changed

3 files changed

+2
-53
lines changed

patches/node/.patches

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ fix_use_crypto_impls_for_compat.patch
2727
fix_window_c-ares_incompatibilities.patch
2828
fix_comment_out_incompatible_crypto_modules.patch
2929
update_tests_after_increasing_typed_array_size.patch
30-
fix_allow_preventing_setpromiserejectcallback.patch
3130
lib_use_non-symbols_in_isurlinstance_check.patch
3231
feat_add_implementation_of_v8_platform_postjob.patch
3332
fix_enable_tls_renegotiation.patch

patches/node/fix_allow_preventing_setpromiserejectcallback.patch

Lines changed: 0 additions & 50 deletions
This file was deleted.

shell/common/node_bindings.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,8 @@ node::Environment* NodeBindings::CreateEnvironment(
433433
// We do not want to use the promise rejection callback that Node.js uses,
434434
// because it does not send PromiseRejectionEvents to the global script
435435
// context. We need to use the one Blink already provides.
436-
is.flags &=
437-
~node::IsolateSettingsFlags::SHOULD_SET_PROMISE_REJECTION_CALLBACK;
436+
is.flags |=
437+
node::IsolateSettingsFlags::SHOULD_SET_PROMISE_REJECTION_CALLBACK;
438438
}
439439

440440
// This needs to be called before the inspector is initialized.

0 commit comments

Comments
 (0)