Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit e13e8fe

Browse files
addaleaxdeepak1556
authored andcommitted
src: remove outdated Neuter() call in node_buffer.cc
This call was introduced in 827ee49 to avoid a crash in a later `Neuter()` call that has later been removed in ebbbc5a, rendering the original call unnecessary. Refs: nodejs/node#3624 Refs: nodejs/node#5204 PR-URL: nodejs/node#25479 Reviewed-By: Anatoli Papirovski <[email protected]>
1 parent 7b35642 commit e13e8fe

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/node_buffer.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -355,11 +355,6 @@ MaybeLocal<Object> New(Environment* env,
355355
}
356356

357357
Local<ArrayBuffer> ab = ArrayBuffer::New(env->isolate(), data, length);
358-
// `Neuter()`ing is required here to prevent materialization of the backing
359-
// store in v8. `nullptr` buffers are not writable, so this is semantically
360-
// correct.
361-
if (data == nullptr)
362-
ab->Neuter();
363358
MaybeLocal<Uint8Array> ui = Buffer::New(env, ab, 0, length);
364359

365360
if (ui.IsEmpty()) {

0 commit comments

Comments
 (0)