From 5c21e322ac25d5a26b66adbc0072dccd2f2eb6ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Samson?= Date: Wed, 18 Jun 2025 09:39:21 +0200 Subject: [PATCH] Fix get_versions return values --- apps/elixir_ls_utils/lib/launch.ex | 8 ++++---- apps/elixir_ls_utils/test/launch_test.exs | 17 +++++++++++++++++ 2 files changed, 21 insertions(+), 4 deletions(-) create mode 100644 apps/elixir_ls_utils/test/launch_test.exs diff --git a/apps/elixir_ls_utils/lib/launch.ex b/apps/elixir_ls_utils/lib/launch.ex index 091134757..d75f00a62 100644 --- a/apps/elixir_ls_utils/lib/launch.ex +++ b/apps/elixir_ls_utils/lib/launch.ex @@ -36,10 +36,10 @@ defmodule ElixirLS.Utils.Launch do def get_versions do %{ - current_elixir_version: inspect(System.build_info()[:build]), - current_otp_version: inspect(System.otp_release()), - compile_elixir_version: inspect(@compiled_elixir_version), - compile_otp_version: inspect(@compiled_otp_version) + current_elixir_version: to_string(System.build_info()[:build]), + current_otp_version: to_string(System.otp_release()), + compile_elixir_version: to_string(@compiled_elixir_version), + compile_otp_version: to_string(@compiled_otp_version) } end diff --git a/apps/elixir_ls_utils/test/launch_test.exs b/apps/elixir_ls_utils/test/launch_test.exs new file mode 100644 index 000000000..12e2341a9 --- /dev/null +++ b/apps/elixir_ls_utils/test/launch_test.exs @@ -0,0 +1,17 @@ +defmodule ElixirLS.Utils.LaunchTest do + use ExUnit.Case, async: true + + test "get_versions returns plain strings" do + versions = ElixirLS.Utils.Launch.get_versions() + + assert is_binary(versions.current_elixir_version) + assert is_binary(versions.current_otp_version) + assert is_binary(versions.compile_elixir_version) + assert is_binary(versions.compile_otp_version) + + for value <- Map.values(versions) do + refute String.starts_with?(value, "\"") + refute String.ends_with?(value, "\"") + end + end +end