From bd86ef0d467406cbcb322b4bcd8759981c1187c1 Mon Sep 17 00:00:00 2001
From: Cheng-Hsuan Tsai <chtsai@CHTSAI.local>
Date: Mon, 9 Dec 2019 15:02:24 -0800
Subject: [PATCH 1/2] {{will-destroy}} does not invoke rendering

---
 .../modifiers/will-destroy-test.js            | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/tests/integration/modifiers/will-destroy-test.js b/tests/integration/modifiers/will-destroy-test.js
index 3ea2726..61a86c9 100644
--- a/tests/integration/modifiers/will-destroy-test.js
+++ b/tests/integration/modifiers/will-destroy-test.js
@@ -1,7 +1,9 @@
+import Component from '@ember/component';
 import { module, test } from 'qunit';
 import { setupRenderingTest } from 'ember-qunit';
 import { render } from '@ember/test-helpers';
 import hbs from 'htmlbars-inline-precompile';
+import { settled } from '@ember/test-helpers';
 
 module('Integration | Modifier | will-destroy', function(hooks) {
   setupRenderingTest(hooks);
@@ -43,4 +45,42 @@ module('Integration | Modifier | will-destroy', function(hooks) {
     // trigger destroy
     this.set('show', false);
   });
+
+  test('it should invoke UI re-rendering when changing tracked properties', async function(assert) {
+    this.owner.register(
+      'component:test-component',
+      Component.extend({
+        showMessage: true,
+
+        actions: {
+          toggle() {
+            this.set('showMessage', false);
+          },
+        },
+      })
+    );
+
+    this.owner.register(
+      'template:components/test-component',
+      hbs`
+        {{#if this.showMessage}}
+          <div data-dummy>Hello Ember</div>
+        {{/if}}
+        {{#if @shouldShow}}
+          <div {{will-destroy (action "toggle")}}></div>
+        {{/if}}
+      `
+    );
+
+    this.set('show', true);
+
+    await render(hbs`<TestComponent @shouldShow={{this.show}}></TestComponent>`);
+    assert.dom('[data-dummy]').exists();
+
+    // trigger destroying. should remove [data-dummy] element.
+    this.set('show', false);
+    await settled();
+
+    assert.dom('[data-dummy]').doesNotExist();
+  });
 });

From 8b59fcc5a82ad2e9ce2be9fc528dbd43e79c6c6b Mon Sep 17 00:00:00 2001
From: Robert Jackson <rjackson@linkedin.com>
Date: Tue, 10 Mar 2020 14:14:50 -0400
Subject: [PATCH 2/2] Attempt to re-run CI against Node 10.

ATM, CI is failing due to unsupported Node engine. I'd like to confirm
that the changes made to the backtracking assertion in Ember 3.15
properly trigger an eager failure in these cases.
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index d8a2d21..a47887c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "6"
+  - "10"
 
 sudo: false
 dist: trusty