Skip to content

Commit af9a397

Browse files
authored
Remove i64x2_{any,all}_true tests (#13199)
These instructions are no longer in the SIMD proposal and were removed from Binaryen, so their presence was causing the SIMD tests to fail. Fixes WebAssembly/binaryen#3468.
1 parent 283603e commit af9a397

File tree

3 files changed

+0
-36
lines changed

3 files changed

+0
-36
lines changed

tests/test_core.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5710,7 +5710,6 @@ def test_relocatable_void_function(self):
57105710

57115711
@wasm_simd
57125712
@is_slow_test
5713-
@disabled('https://github.com/WebAssembly/binaryen/issues/3468')
57145713
def test_wasm_builtin_simd(self):
57155714
# Improves test readability
57165715
self.emcc_args += ['-Wno-c++11-narrowing', '-Wno-format']
@@ -5720,7 +5719,6 @@ def test_wasm_builtin_simd(self):
57205719

57215720
@wasm_simd
57225721
@is_slow_test
5723-
@disabled('https://github.com/WebAssembly/binaryen/issues/3468')
57245722
def test_wasm_intrinsics_simd(self):
57255723
def run():
57265724
self.do_runf(path_from_root('tests', 'test_wasm_intrinsics_simd.c'), 'Success!')

tests/test_wasm_builtin_simd.cpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -441,14 +441,6 @@ i32x4 TESTFN i32x4_mul(i32x4 x, i32x4 y) {
441441
i64x2 TESTFN i64x2_neg(i64x2 vec) {
442442
return -vec;
443443
}
444-
#ifdef __wasm_unimplemented_simd128__
445-
int32_t TESTFN i64x2_any_true(i64x2 vec) {
446-
return __builtin_wasm_any_true_i64x2(vec);
447-
}
448-
int32_t TESTFN i64x2_all_true(i64x2 vec) {
449-
return __builtin_wasm_all_true_i64x2(vec);
450-
}
451-
#endif // __wasm_unimplemented_simd128__
452444
i64x2 TESTFN i64x2_shl(i64x2 vec, int32_t shift) {
453445
return vec << shift;
454446
}
@@ -1253,14 +1245,6 @@ int EMSCRIPTEN_KEEPALIVE __attribute__((__optnone__)) main(int argc, char** argv
12531245

12541246
// i64x2 arithmetic
12551247
expect_vec(i64x2_neg((i64x2){0x8000000000000000, 42}), ((i64x2){0x8000000000000000, -42}));
1256-
#ifdef __wasm_unimplemented_simd128__
1257-
expect_eq(i64x2_any_true((i64x2){0, 0}), 0);
1258-
expect_eq(i64x2_any_true((i64x2){1, 0}), 1);
1259-
expect_eq(i64x2_any_true((i64x2){1, 1}), 1);
1260-
expect_eq(i64x2_all_true((i64x2){0, 0}), 0);
1261-
expect_eq(i64x2_all_true((i64x2){1, 0}), 0);
1262-
expect_eq(i64x2_all_true((i64x2){1, 1}), 1);
1263-
#endif // __wasm_unimplemented_simd128__
12641248
expect_vec(i64x2_shl((i64x2){1, 0x8000000000000000}, 1), ((i64x2){2, 0}));
12651249
expect_vec(i64x2_shl((i64x2){1, 0x8000000000000000}, 64), ((i64x2){1, 0x8000000000000000}));
12661250
expect_vec(i64x2_shr_s((i64x2){1, 0x8000000000000000}, 1), ((i64x2){0, 0xc000000000000000}));

tests/test_wasm_intrinsics_simd.c

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -518,18 +518,6 @@ v128_t TESTFN i32x4_mul(v128_t x, v128_t y) {
518518
v128_t TESTFN i64x2_neg(v128_t vec) {
519519
return wasm_i64x2_neg(vec);
520520
}
521-
522-
#ifdef __wasm_unimplemented_simd128__
523-
524-
bool TESTFN i64x2_any_true(v128_t vec) {
525-
return wasm_i64x2_any_true(vec);
526-
}
527-
bool TESTFN i64x2_all_true(v128_t vec) {
528-
return wasm_i64x2_all_true(vec);
529-
}
530-
531-
#endif // __wasm_unimplemented_simd128__
532-
533521
v128_t TESTFN i64x2_shl(v128_t vec, int32_t shift) {
534522
return wasm_i64x2_shl(vec, shift);
535523
}
@@ -1576,12 +1564,6 @@ int EMSCRIPTEN_KEEPALIVE __attribute__((__optnone__)) main(int argc, char** argv
15761564

15771565
// i64x2 arithmetic
15781566
expect_vec(i64x2_neg((v128_t)i64x2(0x8000000000000000, 42)), i64x2(0x8000000000000000, -42));
1579-
/* expect_eq(i64x2_any_true((v128_t)i64x2(0, 0)), 0); */
1580-
/* expect_eq(i64x2_any_true((v128_t)i64x2(1, 0)), 1); */
1581-
/* expect_eq(i64x2_any_true((v128_t)i64x2(1, 1)), 1); */
1582-
/* expect_eq(i64x2_all_true((v128_t)i64x2(0, 0)), 0); */
1583-
/* expect_eq(i64x2_all_true((v128_t)i64x2(1, 0)), 0); */
1584-
/* expect_eq(i64x2_all_true((v128_t)i64x2(1, 1)), 1); */
15851567

15861568
expect_vec(i64x2_shl((v128_t)i64x2(1, 0x8000000000000000), 1), i64x2(2, 0));
15871569
expect_vec(i64x2_shl((v128_t)i64x2(1, 0x8000000000000000), 64), i64x2(1, 0x8000000000000000));

0 commit comments

Comments
 (0)