-
Notifications
You must be signed in to change notification settings - Fork 3.4k
is allocateUTF8 safe to use ? #9786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We also use |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
@kripken ? |
I don't think there's a reason they are not documented. They are internal APIs so they may change in theory, but they have also been part of the internal API for quite a long time. Hopefully someone will add docs, I'll add some tags to this issue. |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
Well, these functions seem to have disappeared, so I guess we weren't supposed to use them? Can anybody suggest any alternative, or am I just too dense to decipher the (lack of) documentation that will tell me how to access them from a pre-js or post-js? |
Added a comment about this on #17403 which seems to be the culprit here. If there's a workaround please let me know. |
These days you need to explicitly opt into these library functions: Lines 70 to 73 in 7b9747e
|
Thanks! You should mention somewhere that they also need the leading dollar sign... |
In sql.js, we use the
allocateUTF8OnStack
function, and it works. However, the function is nowhere to be found in the official API documentation. Is this an oversight, or is there a reason the function should not be used outside of emscripten itself ?The text was updated successfully, but these errors were encountered: