Skip to content

Search and filter controls for Browsable API & Admin #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomchristie opened this issue Dec 2, 2014 · 9 comments
Closed

Search and filter controls for Browsable API & Admin #2180

tomchristie opened this issue Dec 2, 2014 · 9 comments
Assignees
Milestone

Comments

@tomchristie
Copy link
Member

The search and filter classes should render in the browsable API in a way that ensures they can be used without having to manually edit the URL querystring.

@tomchristie tomchristie self-assigned this Dec 2, 2014
@tomchristie tomchristie added this to the 3.1 Release milestone Dec 2, 2014
@jpadilla
Copy link
Member

jpadilla commented Dec 2, 2014

👍 definitely very useful, but I'm wondering how exactly we'll make filtering work, since filtering can happen for different fields. Would it only work for SearchFilter?

@tomchristie
Copy link
Member Author

Ask me when I get there :p

More seriously tho: I've been assuming we'll need an interface on filter classes that can be used to define if and how they should render to HTML.

@carltongibson
Copy link
Collaborator

Any appetite for pushing whatever is needed/can be pushed into Django Filter here?

I'm more or less on top of the issues backlog there: next up is improving the documentation and then I wanted to think through where it's going — there's seems to be a tendency to sprout new Filter subclasses like mushrooms on a damp night — compatibility with DRF, whilst not everything, seems like an important feature

@tomchristie
Copy link
Member Author

@carltongibson I don't think we'll need to do much pushing into Django Filter. We can probably just add a simple wrapper around its own HTML generation stuff.

@carltongibson
Copy link
Collaborator

OK, well as needed.

@tomchristie tomchristie changed the title Search and filter controls rendering in Browsable API. Search and filter controls rendering in Browsable API Dec 11, 2014
@tomchristie
Copy link
Member Author

Not a distinction that we make any more: https://github.com/tomchristie/django-rest-framework/labels

@tomchristie
Copy link
Member Author

Still very much on the roadmap but I'd like to start tying up 3.1.0 since there's a bunch of great improvements in there already. We may have 3.2.0 for the first portion of HTML stuff and 3.3.0 for the final bit of the admin api work, but currently undecided (may just all be 3.2.0)

@tomchristie tomchristie modified the milestones: 3.2.0 Release, 3.3.0 Jun 3, 2015
@tomchristie tomchristie changed the title Search and filter controls rendering in Browsable API Search and filter controls for Browsable API & Admin Jul 31, 2015
@mihow
Copy link

mihow commented Oct 16, 2015

Are there any branches that include this feature or any commits related to the issue? I'd love to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@carltongibson @jpadilla @mihow @tomchristie and others