Skip to content

Auth token keys should not be the primary key #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
benwilber opened this issue Mar 26, 2019 · 2 comments
Closed
1 task

Auth token keys should not be the primary key #6537

benwilber opened this issue Mar 26, 2019 · 2 comments

Comments

@benwilber
Copy link

Auth tokens should not be the primary key because they are visible in the URL when you visit them in the Django admin. This means that auth tokens are being leaked in access logs of any web server/proxy between the user and the application server

Checklist

  • [* ] I have verified that that issue exists against the master branch of Django REST framework.
  • [* ] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • [* ] This is not a usage question. (Those should be directed to the discussion group instead.)
  • [ *] This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • [* ] I have reduced the issue to the simplest possible case.
  • I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

Go to the auth token admin and observe that the key is leaked in the URL

Expected behavior

Key is not leaked in the URL

Actual behavior

Key is leaked in the URL

@tomchristie
Copy link
Member

Yup, agreed. Main consideration would be how best to migrate to something new.

@carltongibson
Copy link
Collaborator

Duplicate of #6131. (PRs still welcome: shouldn't be too hard...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants