You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although the recent 0.14.0 version adds support for functools.partial for Python 3.6 and Python 3.7, that support appears to be incomplete, not working for classmethods in Python 3.8.
I was unaware of the fact that inspect.iscoroutinefunction does not properly detect a functools.partial as async if it wraps an async classmethod.
TLDR: the previous PR was too cautious, we can always unwrap the functools.partial object to be sure we check the underlying object.
The text was updated successfully, but these errors were encountered:
starlette/starlette/routing.py
Line 38 in e430706
Although the recent 0.14.0 version adds support for functools.partial for Python 3.6 and Python 3.7, that support appears to be incomplete, not working for classmethods in Python 3.8.
I was unaware of the fact that
inspect.iscoroutinefunction
does not properly detect a functools.partial as async if it wraps an async classmethod.TLDR: the previous PR was too cautious, we can always unwrap the functools.partial object to be sure we check the underlying object.
The text was updated successfully, but these errors were encountered: