Implement Path.from in the CanvasKit backend (flutter#14468)

Harry Terkelsen · web-flow · commit 155ee3cb7c30 · 2020-01-08T11:19:39.000-08:00
diff --git a/lib/web_ui/lib/src/engine/compositor/path.dart b/lib/web_ui/lib/src/engine/compositor/path.dart
@@ -15,9 +15,9 @@ class SkPath implements ui.Path {
     fillType = ui.PathFillType.nonZero;
   }
 
-  // TODO(yjbanov): implement: https://github.com/flutter/flutter/issues/46812
   SkPath.from(SkPath other) {
-    throw UnimplementedError('SkPath.from is not implemented in the CanvasKit backend');
+    _skPath = js.JsObject(canvasKit['SkPath'], <js.JsObject>[other._skPath]);
+    fillType = other.fillType;
   }
 
   SkPath._fromSkPath(js.JsObject skPath) : _skPath = skPath;

Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,9 @@ class SkPath implements ui.Path {`
`15`	`15`	`fillType = ui.PathFillType.nonZero;`
`16`	`16`	`}`
`17`	`17`
`18`		`- // TODO(yjbanov): implement: https://github.com/flutter/flutter/issues/46812`
`19`	`18`	`SkPath.from(SkPath other) {`
`20`		`- throw UnimplementedError('SkPath.from is not implemented in the CanvasKit backend');`
	`19`	`+ _skPath = js.JsObject(canvasKit['SkPath'], <js.JsObject>[other._skPath]);`
	`20`	`+ fillType = other.fillType;`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`SkPath._fromSkPath(js.JsObject skPath) : _skPath = skPath;`