Do not call CoreWindow::Visible from raster thread (flutter#27760)

knopp · web-flow · commit 35dfc279c372 · 2021-08-07T22:26:28.000+02:00
diff --git a/shell/platform/windows/flutter_window_winuwp.cc b/shell/platform/windows/flutter_window_winuwp.cc
@@ -118,7 +118,13 @@ float FlutterWindowWinUWP::GetDpiScale() {
 }
 
 bool FlutterWindowWinUWP::IsVisible() {
-  return window_.Visible();
+  // This is called from raster thread as an optimization to not wait for vsync
+  // if window is invisible. However CoreWindow is not agile so we can't call
+  // Visible() from raster thread. For now assume window is always visible.
+  // Possible solution would be to register a VisibilityChanged handler and
+  // store the visiblity state in a variable. TODO(knopp)
+  // https://github.com/flutter/flutter/issues/87870
+  return true;
 }
 
 void FlutterWindowWinUWP::OnDpiChanged(

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,13 @@ float FlutterWindowWinUWP::GetDpiScale() {`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`bool FlutterWindowWinUWP::IsVisible() {`
`121`		`- return window_.Visible();`
	`121`	`+ // This is called from raster thread as an optimization to not wait for vsync`
	`122`	`+ // if window is invisible. However CoreWindow is not agile so we can't call`
	`123`	`+ // Visible() from raster thread. For now assume window is always visible.`
	`124`	`+ // Possible solution would be to register a VisibilityChanged handler and`
	`125`	`+ // store the visiblity state in a variable. TODO(knopp)`
	`126`	`+ // https://github.com/flutter/flutter/issues/87870`
	`127`	`+ return true;`
`122`	`128`	`}`
`123`	`129`
`124`	`130`	`void FlutterWindowWinUWP::OnDpiChanged(`