Skip to content

Commit 3a01f39

Browse files
authored
Change log level from ERROR to WARNING (flutter#6361)
So tool_tests-windows won't fail.
1 parent 5ae4708 commit 3a01f39

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

shell/common/persistent_cache.cc

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ PersistentCache::PersistentCache()
5151
},
5252
fml::FilePermission::kReadWrite))) {
5353
if (!IsValid()) {
54-
FML_LOG(ERROR) << "Could not acquire the persistent cache directory. "
55-
"Caching of GPU resources on disk is disabled.";
54+
FML_LOG(WARNING) << "Could not acquire the persistent cache directory. "
55+
"Caching of GPU resources on disk is disabled.";
5656
}
5757
}
5858

@@ -90,21 +90,23 @@ static void PersistentCacheStore(fml::RefPtr<fml::TaskRunner> worker,
9090
std::shared_ptr<fml::UniqueFD> cache_directory,
9191
std::string key,
9292
std::unique_ptr<fml::Mapping> value) {
93-
auto task = fml::MakeCopyable([cache_directory, //
94-
file_name = std::move(key), //
95-
mapping = std::move(value) //
93+
auto task =
94+
fml::MakeCopyable([cache_directory, //
95+
file_name = std::move(key), //
96+
mapping = std::move(value) //
9697
]() mutable {
97-
TRACE_EVENT0("flutter", "PersistentCacheStore");
98-
if (!fml::WriteAtomically(*cache_directory, //
99-
file_name.c_str(), //
100-
*mapping) //
101-
) {
102-
FML_DLOG(ERROR) << "Could not write cache contents to persistent store.";
103-
}
104-
});
98+
TRACE_EVENT0("flutter", "PersistentCacheStore");
99+
if (!fml::WriteAtomically(*cache_directory, //
100+
file_name.c_str(), //
101+
*mapping) //
102+
) {
103+
FML_DLOG(WARNING)
104+
<< "Could not write cache contents to persistent store.";
105+
}
106+
});
105107

106108
if (!worker) {
107-
FML_LOG(ERROR)
109+
FML_LOG(WARNING)
108110
<< "The persistent cache has no available workers. Performing the task "
109111
"on the current thread. This slow operation is going to occur on a "
110112
"frame workload.";

0 commit comments

Comments
 (0)