Skip to content

Commit 5933993

Browse files
Add missing ignores for textScaleFactor deprecation (flutter#4239)
flutter/packages#4209 missed a few deprecations since it was reformatted and the "ignore" was placed on the incorrect lines. Now `dart analyze --fatal-infos` says no issues found.
1 parent 7365b61 commit 5933993

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

packages/flutter_markdown/lib/src/builder.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -829,17 +829,17 @@ class MarkdownBuilder implements md.NodeVisitor {
829829
if (selectable) {
830830
return SelectableText.rich(
831831
text!,
832-
textScaleFactor:
833-
styleSheet.textScaleFactor, // ignore: deprecated_member_use
832+
// ignore: deprecated_member_use
833+
textScaleFactor: styleSheet.textScaleFactor,
834834
textAlign: textAlign ?? TextAlign.start,
835835
onTap: onTapText,
836836
key: k,
837837
);
838838
} else {
839839
return RichText(
840840
text: text!,
841-
textScaleFactor:
842-
styleSheet.textScaleFactor!, // ignore: deprecated_member_use
841+
// ignore: deprecated_member_use
842+
textScaleFactor: styleSheet.textScaleFactor!,
843843
textAlign: textAlign ?? TextAlign.start,
844844
key: k,
845845
);

packages/flutter_markdown/test/text_scale_factor_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ void defineTests() {
3636
await tester.pumpWidget(
3737
boilerplate(
3838
const MediaQuery(
39-
data: MediaQueryData(
40-
textScaleFactor: 2.0), // ignore: deprecated_member_use
39+
// ignore: deprecated_member_use
40+
data: MediaQueryData(textScaleFactor: 2.0),
4141
child: MarkdownBody(
4242
data: data,
4343
),
@@ -57,8 +57,8 @@ void defineTests() {
5757
await tester.pumpWidget(
5858
boilerplate(
5959
const MediaQuery(
60-
data: MediaQueryData(
61-
textScaleFactor: 2.0), // ignore: deprecated_member_use
60+
// ignore: deprecated_member_use
61+
data: MediaQueryData(textScaleFactor: 2.0),
6262
child: MarkdownBody(
6363
data: data,
6464
selectable: true,
@@ -69,8 +69,8 @@ void defineTests() {
6969

7070
final SelectableText selectableText =
7171
tester.widget(find.byType(SelectableText));
72-
expect(selectableText.textScaleFactor,
73-
2.0); // ignore: deprecated_member_use
72+
// ignore: deprecated_member_use
73+
expect(selectableText.textScaleFactor, 2.0);
7474
},
7575
);
7676
});

0 commit comments

Comments
 (0)