You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: lib/spirv/README.md
+6-6Lines changed: 6 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -27,7 +27,7 @@ the code will need to adhere to the following rules.
27
27
- Only built-in functions present in GLSL ES 100 are used.
28
28
- Debug symbols must be stripped, you can use the `spirv-opt``--strip-debug` flag.
29
29
30
-
These rules may become less strict in future versions. Confirmant SPIR-V should succesfully transpile from the current version onwards. In other words, a spir-v shader you use now that meets these rules should keep working, but the output of the transpiler may change for that shader.
30
+
These rules may become less strict in future versions. Conformant SPIR-V should successfully transpile from the current version onwards. In other words, a SPIR-V shader you use now that meets these rules should keep working, but the output of the transpiler may change for that shader.
31
31
32
32
Support for textures, control flow, and structured types is planned, but not currently included.
33
33
@@ -41,7 +41,7 @@ To test the exception tests directly: `./testing/run_tests.py --type dart --dart
41
41
42
42
### Pixel Tests
43
43
44
-
Pixel tests should run as part of unit-testing for each implementation of `dart:ui`. Currently, FragmentShader is only supported in C++. These tests aim to validate the correctness of transpilation to each target language. Each shader should render the color green for a correct transpilation, and any other color for failure. They will be a GLSL files that are compiled to SPIR-V via `shaderc`. Therefor, the `fragColor` should resolve to `vec4(0.0, 1.0, 0.0, 1.0)`
44
+
Pixel tests should run as part of unit-testing for each implementation of `dart:ui`. Currently, FragmentShader is only supported in C++. These tests aim to validate the correctness of transpilation to each target language. Each shader should render the color green for a correct transpilation, and any other color for failure. They will be a GLSL files that are compiled to SPIR-V via `shaderc`. Therefore, the `fragColor` should resolve to `vec4(0.0, 1.0, 0.0, 1.0)`
45
45
for all tests.
46
46
47
47
In each test, the uniform `a` is initialized with the value of 1.0.
@@ -51,15 +51,15 @@ To test the pixel tests directly: `./testing/run_tests.py --type dart --dart-fil
51
51
52
52
#### A Note on Test Isolation
53
53
54
-
Even the simplest GLSL program tests several instructions, so no test us completely isolated
55
-
to a single op. Also, some of the GLSL 450 op tests will use addition in subtraction, along with the
54
+
Even the simplest GLSL program tests several instructions, so no test is completely isolated
55
+
to a single op. Also, some of the GLSL 450 op tests will use addition and subtraction, along with the
56
56
actual op being tested. However, the GLSL program for each test file is kept as simple as possible,
57
57
to satisfy these conditions: pass if the op works, and fail if the op does not work. In some tests,
58
-
it is sufficient to only call the GLSL op once, while other may need more calls to more completelty
58
+
it is sufficient to only call the GLSL op once, while other may need more calls to more completely
59
59
test the op. Many ops support scalars, vectors, or a combination as parameters. Most tests default
60
60
to using scalars as params, but vec2, vec3, and vec4 parameters are also tested.
61
61
62
-
- vec2 is tested as a paramter in glsl_op_normalize.glsl
62
+
- vec2 is tested as a parameter in glsl_op_normalize.glsl
63
63
- vec3 is tested as a parameter in glsl_op_cross.glsl
64
64
- vec4 is tested as a parameter in glsl_op_length.glsl
0 commit comments