Skip to content

Commit c5c8cda

Browse files
author
Harry Terkelsen
authored
[url_launcher] Mark Link as an invisible factory (flutter#4578)
1 parent 9b2d46a commit c5c8cda

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

packages/url_launcher/url_launcher_web/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.0.7
2+
3+
* Marks the `Link` widget as invisible so it can be optimized by the engine.
4+
15
## 2.0.6
26

37
* Removes dependency on `meta`.

packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ class platformViewRegistry {
1616
/// Shim for registerViewFactory
1717
/// https://github.com/flutter/engine/blob/master/lib/web_ui/lib/ui.dart#L72
1818
static bool registerViewFactory(
19-
String viewTypeId, html.Element Function(int viewId) viewFactory) {
19+
String viewTypeId, html.Element Function(int viewId) viewFactory,
20+
{bool isVisible = true}) {
2021
return false;
2122
}
2223
}

packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ class UrlLauncherPlugin extends UrlLauncherPlatform {
4646
/// Registers this class as the default instance of [UrlLauncherPlatform].
4747
static void registerWith(Registrar registrar) {
4848
UrlLauncherPlatform.instance = UrlLauncherPlugin();
49-
ui.platformViewRegistry.registerViewFactory(linkViewType, linkViewFactory);
49+
ui.platformViewRegistry
50+
.registerViewFactory(linkViewType, linkViewFactory, isVisible: false);
5051
}
5152

5253
@override

packages/url_launcher/url_launcher_web/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: url_launcher_web
22
description: Web platform implementation of url_launcher
33
repository: https://github.com/flutter/plugins/tree/main/packages/url_launcher/url_launcher_web
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
5-
version: 2.0.6
5+
version: 2.0.7
66

77
environment:
88
sdk: ">=2.12.0 <3.0.0"

0 commit comments

Comments
 (0)