Skip to content

Commit cef91bc

Browse files
Ignore textScaleFactor deprecation (flutter#4209)
Ignore `textScaleFactor` deprecation, as suggested in flutter#128825
1 parent b589429 commit cef91bc

File tree

5 files changed

+17
-10
lines changed

5 files changed

+17
-10
lines changed

packages/flutter_markdown/lib/src/_functions_io.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ final MarkdownStyleSheet Function(BuildContext, MarkdownStyleSheetBaseTheme?)
6666
}
6767

6868
return result.copyWith(
69-
textScaleFactor: MediaQuery.textScaleFactorOf(context),
69+
textScaleFactor:
70+
MediaQuery.textScaleFactorOf(context), // ignore: deprecated_member_use
7071
);
7172
};
7273

packages/flutter_markdown/lib/src/_functions_web.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ final MarkdownStyleSheet Function(BuildContext, MarkdownStyleSheetBaseTheme?)
6868
}
6969

7070
return result.copyWith(
71-
textScaleFactor: MediaQuery.textScaleFactorOf(context),
71+
textScaleFactor:
72+
MediaQuery.textScaleFactorOf(context), // ignore: deprecated_member_use
7273
);
7374
};
7475

packages/flutter_markdown/lib/src/builder.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -829,15 +829,17 @@ class MarkdownBuilder implements md.NodeVisitor {
829829
if (selectable) {
830830
return SelectableText.rich(
831831
text!,
832-
textScaleFactor: styleSheet.textScaleFactor,
832+
textScaleFactor:
833+
styleSheet.textScaleFactor, // ignore: deprecated_member_use
833834
textAlign: textAlign ?? TextAlign.start,
834835
onTap: onTapText,
835836
key: k,
836837
);
837838
} else {
838839
return RichText(
839840
text: text!,
840-
textScaleFactor: styleSheet.textScaleFactor!,
841+
textScaleFactor:
842+
styleSheet.textScaleFactor!, // ignore: deprecated_member_use
841843
textAlign: textAlign ?? TextAlign.start,
842844
key: k,
843845
);

packages/flutter_markdown/test/text_scale_factor_test.dart

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ void defineTests() {
2525
);
2626

2727
final RichText richText = tester.widget(find.byType(RichText));
28-
expect(richText.textScaleFactor, 2.0);
28+
expect(richText.textScaleFactor, 2.0); // ignore: deprecated_member_use
2929
},
3030
);
3131

@@ -36,7 +36,8 @@ void defineTests() {
3636
await tester.pumpWidget(
3737
boilerplate(
3838
const MediaQuery(
39-
data: MediaQueryData(textScaleFactor: 2.0),
39+
data: MediaQueryData(
40+
textScaleFactor: 2.0), // ignore: deprecated_member_use
4041
child: MarkdownBody(
4142
data: data,
4243
),
@@ -45,7 +46,7 @@ void defineTests() {
4546
);
4647

4748
final RichText richText = tester.widget(find.byType(RichText));
48-
expect(richText.textScaleFactor, 2.0);
49+
expect(richText.textScaleFactor, 2.0); // ignore: deprecated_member_use
4950
},
5051
);
5152

@@ -56,7 +57,8 @@ void defineTests() {
5657
await tester.pumpWidget(
5758
boilerplate(
5859
const MediaQuery(
59-
data: MediaQueryData(textScaleFactor: 2.0),
60+
data: MediaQueryData(
61+
textScaleFactor: 2.0), // ignore: deprecated_member_use
6062
child: MarkdownBody(
6163
data: data,
6264
selectable: true,
@@ -67,7 +69,8 @@ void defineTests() {
6769

6870
final SelectableText selectableText =
6971
tester.widget(find.byType(SelectableText));
70-
expect(selectableText.textScaleFactor, 2.0);
72+
expect(selectableText.textScaleFactor,
73+
2.0); // ignore: deprecated_member_use
7174
},
7275
);
7376
});

packages/rfw/lib/src/flutter/core_widgets.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,7 @@ Map<String, LocalWidgetBuilder> get _coreWidgetsDefinitions => <String, LocalWid
644644
locale: ArgumentDecoders.locale(source, ['locale']),
645645
softWrap: source.v<bool>(['softWrap']),
646646
overflow: ArgumentDecoders.enumValue<TextOverflow>(TextOverflow.values, source, ['overflow']),
647-
textScaleFactor: source.v<double>(['textScaleFactor']),
647+
textScaleFactor: source.v<double>(['textScaleFactor']), // ignore: deprecated_member_use
648648
maxLines: source.v<int>(['maxLines']),
649649
semanticsLabel: source.v<String>(['semanticsLabel']),
650650
textWidthBasis: ArgumentDecoders.enumValue<TextWidthBasis>(TextWidthBasis.values, source, ['textWidthBasis']),

0 commit comments

Comments
 (0)