Skip to content

Commit f185bff

Browse files
authored
[url_launcher] Add ignores for deprecated member to test (flutter#4220)
We are going to deprecate `RendererBinding.renderView` for multi-view where the binding will manages multiple RenderViews. Change for that is staged in flutter#125003.
1 parent 6a51bef commit f185bff

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

packages/url_launcher/url_launcher/test/src/legacy_api_test.dart

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import 'dart:ui' show Brightness;
88

99
import 'package:flutter/foundation.dart';
10+
import 'package:flutter/rendering.dart';
1011
import 'package:flutter/services.dart' show PlatformException;
1112
import 'package:flutter_test/flutter_test.dart';
1213
import 'package:url_launcher/src/legacy_api.dart';
@@ -241,15 +242,18 @@ void main() {
241242
_anonymize(TestWidgetsFlutterBinding.ensureInitialized())!
242243
as TestWidgetsFlutterBinding;
243244
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
244-
binding.renderView.automaticSystemUiAdjustment = true;
245+
// TODO(goderbauer): Migrate to binding.renderViews when that is available in the oldest supported stable.
246+
final RenderView renderView =
247+
binding.renderView; // ignore: deprecated_member_use
248+
renderView.automaticSystemUiAdjustment = true;
245249
final Future<bool> launchResult =
246250
launch('http://flutter.dev/', statusBarBrightness: Brightness.dark);
247251

248252
// Should take over control of the automaticSystemUiAdjustment while it's
249253
// pending, then restore it back to normal after the launch finishes.
250-
expect(binding.renderView.automaticSystemUiAdjustment, isFalse);
254+
expect(renderView.automaticSystemUiAdjustment, isFalse);
251255
await launchResult;
252-
expect(binding.renderView.automaticSystemUiAdjustment, isTrue);
256+
expect(renderView.automaticSystemUiAdjustment, isTrue);
253257
});
254258

255259
test('sets automaticSystemUiAdjustment to not be null', () async {
@@ -270,15 +274,18 @@ void main() {
270274
_anonymize(TestWidgetsFlutterBinding.ensureInitialized())!
271275
as TestWidgetsFlutterBinding;
272276
debugDefaultTargetPlatformOverride = TargetPlatform.android;
273-
expect(binding.renderView.automaticSystemUiAdjustment, true);
277+
// TODO(goderbauer): Migrate to binding.renderViews when that is available in the oldest supported stable.
278+
final RenderView renderView =
279+
binding.renderView; // ignore: deprecated_member_use
280+
expect(renderView.automaticSystemUiAdjustment, true);
274281
final Future<bool> launchResult =
275282
launch('http://flutter.dev/', statusBarBrightness: Brightness.dark);
276283

277284
// The automaticSystemUiAdjustment should be set before the launch
278285
// and equal to true after the launch result is complete.
279-
expect(binding.renderView.automaticSystemUiAdjustment, true);
286+
expect(renderView.automaticSystemUiAdjustment, true);
280287
await launchResult;
281-
expect(binding.renderView.automaticSystemUiAdjustment, true);
288+
expect(renderView.automaticSystemUiAdjustment, true);
282289
});
283290

284291
test('open non-parseable url', () async {

0 commit comments

Comments
 (0)