Skip to content

Commit 237db2b

Browse files
authored
cover more tests with leak tracing (#134834)
1 parent 2868bc1 commit 237db2b

File tree

5 files changed

+17
-12
lines changed

5 files changed

+17
-12
lines changed

packages/flutter/test/semantics/semantics_binding_test.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@
44

55
import 'package:flutter/semantics.dart';
66
import 'package:flutter_test/flutter_test.dart';
7+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
78

89
void main() {
9-
testWidgets('Listeners are called when semantics are turned on with ensureSemantics', (WidgetTester tester) async {
10+
testWidgetsWithLeakTracking('Listeners are called when semantics are turned on with ensureSemantics', (WidgetTester tester) async {
1011
expect(SemanticsBinding.instance.semanticsEnabled, isFalse);
1112

1213
final List<bool> status = <bool>[];
@@ -43,7 +44,7 @@ void main() {
4344
expect(SemanticsBinding.instance.semanticsEnabled, isFalse);
4445
}, semanticsEnabled: false);
4546

46-
testWidgets('Listeners are called when semantics are turned on by platform', (WidgetTester tester) async {
47+
testWidgetsWithLeakTracking('Listeners are called when semantics are turned on by platform', (WidgetTester tester) async {
4748
expect(SemanticsBinding.instance.semanticsEnabled, isFalse);
4849

4950
final List<bool> status = <bool>[];
@@ -69,7 +70,7 @@ void main() {
6970
expect(SemanticsBinding.instance.semanticsEnabled, isFalse);
7071
}, semanticsEnabled: false);
7172

72-
testWidgets('SemanticsBinding.ensureSemantics triggers creation of semantics owner.', (WidgetTester tester) async {
73+
testWidgetsWithLeakTracking('SemanticsBinding.ensureSemantics triggers creation of semantics owner.', (WidgetTester tester) async {
7374
expect(SemanticsBinding.instance.semanticsEnabled, isFalse);
7475
expect(tester.binding.pipelineOwner.semanticsOwner, isNull);
7576

packages/flutter/test/semantics/semantics_elevation_test.dart

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55
import 'package:flutter/material.dart';
66
import 'package:flutter/rendering.dart';
77
import 'package:flutter_test/flutter_test.dart';
8+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
89

910
import '../widgets/semantics_tester.dart';
1011

1112
void main() {
12-
testWidgets('SemanticsNodes overlapping in z', (WidgetTester tester) async {
13+
testWidgetsWithLeakTracking('SemanticsNodes overlapping in z', (WidgetTester tester) async {
1314
// Cards are semantic boundaries that always own their own SemanticNode,
1415
// PhysicalModels merge their semantics information into parent.
1516
//
@@ -97,7 +98,7 @@ void main() {
9798
semantics.dispose();
9899
});
99100

100-
testWidgets('SemanticsNodes overlapping in z with switched children', (WidgetTester tester) async {
101+
testWidgetsWithLeakTracking('SemanticsNodes overlapping in z with switched children', (WidgetTester tester) async {
101102
// Same as 'SemanticsNodes overlapping in z', but the order of children
102103
// is reversed
103104

@@ -173,7 +174,7 @@ void main() {
173174
semantics.dispose();
174175
});
175176

176-
testWidgets('single node thickness', (WidgetTester tester) async {
177+
testWidgetsWithLeakTracking('single node thickness', (WidgetTester tester) async {
177178
final SemanticsTester semantics = SemanticsTester(tester);
178179

179180
await tester.pumpWidget(const MaterialApp(
@@ -193,7 +194,7 @@ void main() {
193194
semantics.dispose();
194195
});
195196

196-
testWidgets('force-merge', (WidgetTester tester) async {
197+
testWidgetsWithLeakTracking('force-merge', (WidgetTester tester) async {
197198
final SemanticsTester semantics = SemanticsTester(tester);
198199

199200
await tester.pumpWidget(MaterialApp(
@@ -247,7 +248,7 @@ void main() {
247248
semantics.dispose();
248249
});
249250

250-
testWidgets('force-merge with inversed children', (WidgetTester tester) async {
251+
testWidgetsWithLeakTracking('force-merge with inversed children', (WidgetTester tester) async {
251252
final SemanticsTester semantics = SemanticsTester(tester);
252253

253254
await tester.pumpWidget(MaterialApp(

packages/flutter/test/semantics/semantics_owner_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55
import 'package:flutter/material.dart';
66
import 'package:flutter/semantics.dart';
77
import 'package:flutter_test/flutter_test.dart';
8+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
89

910
import '../widgets/semantics_tester.dart';
1011

1112
void main() {
12-
testWidgets('Performing SemanticsAction.showOnScreen does not crash if node no longer exist', (WidgetTester tester) async {
13+
testWidgetsWithLeakTracking('Performing SemanticsAction.showOnScreen does not crash if node no longer exist', (WidgetTester tester) async {
1314
// Regression test for https://github.com/flutter/flutter/issues/100358.
1415

1516
final SemanticsTester semantics = SemanticsTester(tester);

packages/flutter/test/semantics/semantics_update_test.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@ import 'dart:ui' as ui;
88
import 'package:flutter/material.dart';
99
import 'package:flutter/semantics.dart';
1010
import 'package:flutter_test/flutter_test.dart';
11+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
1112

1213
void main() {
1314
SemanticsUpdateTestBinding();
1415

15-
testWidgets('Semantics update does not send update for merged nodes.', (WidgetTester tester) async {
16+
testWidgetsWithLeakTracking('Semantics update does not send update for merged nodes.', (WidgetTester tester) async {
1617
final SemanticsHandle handle = tester.ensureSemantics();
1718
// Pumps a placeholder to trigger the warm up frame.
1819
await tester.pumpWidget(
@@ -85,7 +86,7 @@ void main() {
8586
handle.dispose();
8687
});
8788

88-
testWidgets('Semantics update receives attributed text', (WidgetTester tester) async {
89+
testWidgetsWithLeakTracking('Semantics update receives attributed text', (WidgetTester tester) async {
8990
final SemanticsHandle handle = tester.ensureSemantics();
9091
// Pumps a placeholder to trigger the warm up frame.
9192
await tester.pumpWidget(

packages/flutter/test/semantics/traversal_order_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44

55
import 'package:flutter/material.dart';
66
import 'package:flutter_test/flutter_test.dart';
7+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
78

89
import '../widgets/semantics_tester.dart';
910

1011
void main() {
11-
testWidgets('Traversal order handles touching elements', (WidgetTester tester) async {
12+
testWidgetsWithLeakTracking('Traversal order handles touching elements', (WidgetTester tester) async {
1213
final SemanticsTester semantics = SemanticsTester(tester);
1314
await tester.pumpWidget(
1415
MaterialApp(

0 commit comments

Comments
 (0)