Skip to content

Commit c9ee9ad

Browse files
authored
Clean up leaky test. (#152094)
1 parent c637333 commit c9ee9ad

File tree

1 file changed

+18
-3
lines changed

1 file changed

+18
-3
lines changed

packages/flutter/test/material/carousel_test.dart

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,11 +256,14 @@ void main() {
256256
});
257257

258258
testWidgets('CarouselController initialItem', (WidgetTester tester) async {
259+
final CarouselController controller = CarouselController(initialItem: 5);
260+
addTearDown(controller.dispose);
261+
259262
await tester.pumpWidget(
260263
MaterialApp(
261264
home: Scaffold(
262265
body: CarouselView(
263-
controller: CarouselController(initialItem: 5),
266+
controller: controller,
264267
itemExtent: 400,
265268
children: List<Widget>.generate(10, (int index) {
266269
return Center(
@@ -290,11 +293,14 @@ void main() {
290293
});
291294

292295
testWidgets('CarouselView.weighted respects CarouselController.initialItem', (WidgetTester tester) async {
296+
final CarouselController controller = CarouselController(initialItem: 5);
297+
addTearDown(controller.dispose);
298+
293299
await tester.pumpWidget(
294300
MaterialApp(
295301
home: Scaffold(
296302
body: CarouselView.weighted(
297-
controller: CarouselController(initialItem: 5),
303+
controller: controller,
298304
flexWeights: const <int>[7, 1],
299305
children: List<Widget>.generate(10, (int index) {
300306
return Center(
@@ -324,11 +330,14 @@ void main() {
324330
});
325331

326332
testWidgets('The initialItem should be the first item with expanded size(max extent)', (WidgetTester tester) async {
333+
final CarouselController controller = CarouselController(initialItem: 5);
334+
addTearDown(controller.dispose);
335+
327336
await tester.pumpWidget(
328337
MaterialApp(
329338
home: Scaffold(
330339
body: CarouselView.weighted(
331-
controller: CarouselController(initialItem: 5),
340+
controller: controller,
332341
flexWeights: const <int>[1, 8, 1],
333342
children: List<Widget>.generate(10, (int index) {
334343
return Center(
@@ -945,6 +954,8 @@ void main() {
945954

946955
testWidgets('The initialItem stays when the flexWeights is updated', (WidgetTester tester) async {
947956
final CarouselController controller = CarouselController(initialItem: 3);
957+
addTearDown(controller.dispose);
958+
948959
Widget buildCarousel(List<int> flexWeights) {
949960
return MaterialApp(
950961
home: Scaffold(
@@ -991,6 +1002,8 @@ void main() {
9911002

9921003
testWidgets('The item that currently occupies max weight stays when the flexWeights is updated', (WidgetTester tester) async {
9931004
final CarouselController controller = CarouselController(initialItem: 3);
1005+
addTearDown(controller.dispose);
1006+
9941007
Widget buildCarousel(List<int> flexWeights) {
9951008
return MaterialApp(
9961009
home: Scaffold(
@@ -1038,6 +1051,8 @@ void main() {
10381051

10391052
testWidgets('The initialItem stays when the itemExtent is updated', (WidgetTester tester) async {
10401053
final CarouselController controller = CarouselController(initialItem: 3);
1054+
addTearDown(controller.dispose);
1055+
10411056
Widget buildCarousel(double itemExtent) {
10421057
return MaterialApp(
10431058
home: Scaffold(

0 commit comments

Comments
 (0)