Skip to content

Commit f5e8fc3

Browse files
authored
Skip web hot reload tests that test execution for all platforms for now (#162682)
flutter/flutter#162567 There's a general timing error that may occur when loading scripts, where main might be run before the scripts are done loading, leading to a crash. These tests test that output is being printed to stdout, and wait forever for that, leading to timeouts. This is flaky, so the race condition may or may not occur. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. Example of a timeout: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tool_tests/50762/overview
1 parent 93fb582 commit f5e8fc3

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

packages/flutter_tools/test/web.shard/hot_reload_web_test.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
@Tags(<String>['flutter-test-driver'])
66
library;
77

8-
import 'dart:io';
9-
108
import '../integration.shard/test_data/hot_reload_test_common.dart';
119
import '../src/common.dart';
1210

@@ -17,6 +15,6 @@ void main() {
1715
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
1816
],
1917
// https://github.com/flutter/flutter/issues/162567
20-
skip: Platform.isWindows,
18+
skip: true,
2119
);
2220
}

packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
@Tags(<String>['flutter-test-driver'])
66
library;
77

8-
import 'dart:io';
9-
108
import '../integration.shard/test_data/hot_reload_with_asset_test_common.dart';
119
import '../src/common.dart';
1210

@@ -17,6 +15,6 @@ void main() {
1715
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
1816
],
1917
// https://github.com/flutter/flutter/issues/162567
20-
skip: Platform.isWindows,
18+
skip: true,
2119
);
2220
}

packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
@Tags(<String>['flutter-test-driver'])
66
library;
77

8-
import 'dart:io';
9-
108
import '../integration.shard/test_data/stateless_stateful_hot_reload_test_common.dart';
119
import '../src/common.dart';
1210

@@ -17,6 +15,6 @@ void main() {
1715
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
1816
],
1917
// https://github.com/flutter/flutter/issues/162567
20-
skip: Platform.isWindows,
18+
skip: true,
2119
);
2220
}

0 commit comments

Comments
 (0)