fix(zigbee_ep): rooling back to use malloc for remote attr reading

Author: SuGlider

libraries/Zigbee/src/ZigbeeEP.cpp

@@ -19,8 +19,8 @@ ZigbeeEP::ZigbeeEP(uint8_t endpoint) {
   _ep_config.endpoint = 0;
   _cluster_list = nullptr;
   _on_identify = nullptr;
-  _read_model[0] = '\0';
-  _read_manufacturer[0] = '\0';  
+  _read_model = NULL;
+  _read_manufacturer = NULL;  
   _time_status = 0;
   if (!lock) {
     lock = xSemaphoreCreateBinary();
@@ -168,8 +168,11 @@ char *ZigbeeEP::readManufacturer(uint8_t endpoint, uint16_t short_addr, esp_zb_i
   read_req.attr_number = ZB_ARRAY_LENTH(attributes);
   read_req.attr_field = attributes;
 
-  _read_manufacturer[0] = '\0';
-
+  if (_read_manufacturer != NULL) {
+    free(_read_manufacturer);
+  }
+  _read_manufacturer = NULL;
+  
   esp_zb_lock_acquire(portMAX_DELAY);
   esp_zb_zcl_read_attr_cmd_req(&read_req);
   esp_zb_lock_release();
@@ -203,7 +206,10 @@ char *ZigbeeEP::readModel(uint8_t endpoint, uint16_t short_addr, esp_zb_ieee_add
   read_req.attr_number = ZB_ARRAY_LENTH(attributes);
   read_req.attr_field = attributes;
 
-  _read_model[0] = '\0';
+ if (_read_model != NULL) {
+    free(_read_model);
+  }
+  _read_model = NULL;
 
   esp_zb_lock_acquire(portMAX_DELAY);
   esp_zb_zcl_read_attr_cmd_req(&read_req);
@@ -244,13 +250,15 @@ void ZigbeeEP::zbReadBasicCluster(const esp_zb_zcl_attribute_t *attribute) {
   /* Basic cluster attributes */
   if (attribute->id == ESP_ZB_ZCL_ATTR_BASIC_MANUFACTURER_NAME_ID && attribute->data.type == ESP_ZB_ZCL_ATTR_TYPE_CHAR_STRING && attribute->data.value) {
     zbstring_t *zbstr = (zbstring_t *)attribute->data.value;
+    char *_read_manufacturer = (char *) malloc(zbstr->len + 1);
     memcpy(_read_manufacturer, zbstr->data, zbstr->len);
     _read_manufacturer[zbstr->len] = '\0';
     log_i("Peer Manufacturer is \"%s\"", _read_manufacturer);
     xSemaphoreGive(lock);
   }
   if (attribute->id == ESP_ZB_ZCL_ATTR_BASIC_MODEL_IDENTIFIER_ID && attribute->data.type == ESP_ZB_ZCL_ATTR_TYPE_CHAR_STRING && attribute->data.value) {
     zbstring_t *zbstr = (zbstring_t *)attribute->data.value;
+    char *_read_model = (char *) malloc(zbstr->len + 1);
     memcpy(_read_model, zbstr->data, zbstr->len);
     _read_model[zbstr->len] = '\0';
     log_i("Peer Model is \"%s\"", _read_model);