Skip to content

[Question] Increase HTTPD_MAX_REQ_HDR_LEN? #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rtrbt opened this issue Jul 26, 2021 · 4 comments
Closed

[Question] Increase HTTPD_MAX_REQ_HDR_LEN? #5454

rtrbt opened this issue Jul 26, 2021 · 4 comments

Comments

@rtrbt
Copy link
Contributor

rtrbt commented Jul 26, 2021

Hi,

Would it be possible to increase (CONFIG_)HTTPD_MAX_REQ_HDR_LEN? Currently it is set to 512, however in some use cases web browsers send longer headers. An example: I'm using the Espressif HTTP server with digest authentication. The authorization header itself is 267 bytes long, all headers together around 550 bytes.

Bumping the max header length to e.g. 768 or 1024 would only increase the RAM usage if the Espressif HTTP server is used and only by the configured amount: HTTPD_MAX_REQ_HDR_LEN is only used for the HTTPD_SCRATCH_BUF that is allocated only once as far as I have seen it in the code.

Some other users had the same problem in the past: #2983

I'm currently compiling the libs myself with the lib-builder but this seems to be broken at the moment (#5435).

@stale
Copy link

stale bot commented Oct 2, 2021

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Oct 2, 2021
@VojtechBartoska VojtechBartoska added Type: Feature request Feature request for Arduino ESP32 Status: Awaiting triage Issue is waiting for triage and removed Status: Stale Issue is stale stage (outdated/stuck) labels Mar 30, 2022
@VojtechBartoska
Copy link
Contributor

Hello @rtrbt , we will take a look on this.

@rtrbt
Copy link
Contributor Author

rtrbt commented Mar 31, 2022

Thanks, but this is already done: espressif/esp32-arduino-lib-builder@5a8939e9

@rtrbt rtrbt closed this as completed Mar 31, 2022
@VojtechBartoska VojtechBartoska removed Type: Feature request Feature request for Arduino ESP32 Status: Awaiting triage Issue is waiting for triage labels Mar 31, 2022
@tettey-exploits
Copy link

Hi.... how do I use this on windows please...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants