Skip to content

MacOS: possible data loss/corruption #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
networkimprov opened this issue Sep 12, 2018 · 2 comments
Closed

MacOS: possible data loss/corruption #124

networkimprov opened this issue Sep 12, 2018 · 2 comments

Comments

@networkimprov
Copy link

networkimprov commented Sep 12, 2018 •
edited
Loading

fsync() on MacOS does not sync to disk; the correct sync method on MacOS is via fcntl(). Golang os.File.Sync() doesn't do this in version <= 1.11. A fix is in place for 1.12. golang/go#26650

Replace os.File.Sync calls with a direct syscall as a workaround until Go 1.12. golang/go@be10ad7

Related: golang/go#27415
This was referenced Sep 12, 2018
Closed
Open
@networkimprov networkimprov changed the title MacOS fsync() does not sync to disk; data loss/corruption possible MacOS: possible data loss/corruption Sep 12, 2018
@jared2501 jared2501 mentioned this issue Mar 3, 2019
Closed
@patrocinio
Copy link

Hello @networkimprov,

do you have a way to recreate this scenario?

Thanks

@networkimprov
Copy link
Author

Since Go 1.11 is no longer supported, this issue is probably moot.

I believe demonstrating this issue entails an OS crash or unexpected power-loss, e.g. a battery failure.

@cenkalti cenkalti closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patrocinio @networkimprov @cenkalti