Skip to content

Commit e4ea26d

Browse files
committed
Clarifying TODO around searching for the right calldata to fill rlp
1 parent 959ce53 commit e4ea26d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tests/osaka/eip7934_block_rlp_limit/test_max_block_rlp_size.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,10 @@ def exact_size_transactions(
129129
remaining_bytes = target_size - current_size
130130
remaining_gas = max_block_gas - total_gas_used
131131

132+
# TODO: This maybe does not need to be so dynamic and can be more deterministic. We
133+
# should look into the rlp encoding for an empty transaction compared with one
134+
# where only the calldata grows enough to fit the exact rlp, do the calculation,
135+
# and use that transaction here instead of searching for the answer.
132136
if remaining_bytes > 0 and remaining_gas > 50_000:
133137
base_tx = Transaction(
134138
sender=sender,
@@ -315,7 +319,7 @@ def test_multiple_transactions_exceed_limit(
315319
# way, this is currently testing the boundary... we just need a better setup.
316320
# @pytest.mark.exception_test
317321
@pytest.mark.parametrize("from_limit", [-1, 0, 1])
318-
def test_block_at_exact_rlp_size_limit(
322+
def test_block_at_rlp_size_limit_boundary(
319323
blockchain_test: BlockchainTestFiller,
320324
pre: Alloc,
321325
post: Alloc,

0 commit comments

Comments
 (0)