internal/ethapi: add note about eth_chainId compatibility with EIP-695 (#25168)

lightclient · fjl · web-flow · commit c7f485d9e5b9 · 2022-06-25T21:34:21.000+02:00
Co-authored-by: Felix Lange &lt;fjl@twurst.com&gt;
diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go
@@ -609,6 +609,11 @@ func NewBlockChainAPI(b Backend) *BlockChainAPI {
 }
 
 // ChainId is the EIP-155 replay-protection chain id for the current Ethereum chain config.
+//
+// Note, this method does not conform to EIP-695 because the configured chain ID is always
+// returned, regardless of the current head block. We used to return an error when the chain
+// wasn't synced up to a block where EIP-155 is enabled, but this behavior caused issues
+// in CL clients.
 func (api *BlockChainAPI) ChainId() *hexutil.Big {
 	return (*hexutil.Big)(api.b.ChainConfig().ChainID)
 }

Original file line number	Diff line number	Diff line change
`@@ -609,6 +609,11 @@ func NewBlockChainAPI(b Backend) *BlockChainAPI {`
`609`	`609`	`}`
`610`	`610`
`611`	`611`	`// ChainId is the EIP-155 replay-protection chain id for the current Ethereum chain config.`
	`612`	`+//`
	`613`	`+// Note, this method does not conform to EIP-695 because the configured chain ID is always`
	`614`	`+// returned, regardless of the current head block. We used to return an error when the chain`
	`615`	`+// wasn't synced up to a block where EIP-155 is enabled, but this behavior caused issues`
	`616`	`+// in CL clients.`
`612`	`617`	`func (api BlockChainAPI) ChainId() hexutil.Big {`
`613`	`618`	`return (*hexutil.Big)(api.b.ChainConfig().ChainID)`
`614`	`619`	`}`