res.send cause process exit without a catchable exception

[calidion]

I have encountered process exit with res.send which will not throw any exception when the res has been terminated by the peer server.
this can be reproduce again and again.
if i comment res.send, then the node process won't exit anymore.

[brandonburkett]

I am having this issue as well with node 5.3 and express 4.13.3

return res.status(err.status || 500).send((['development'].indexOf(process.env.NODE_ENV) !== -1) ? err : {message: 'something went wrong'});

Process finished with exit code 139
Segmentation fault: 11

[dougwilson]

Hi you guys. Unfortunately trying that code snippet does not cause the app to exit for me. In order for us to take a look, please provide the following information:

1. What exact version of express are you using?
2. What exact version of Node.js are you using?
3. A full app we can copy and paste into a file and run that reproduces the issue.
4. The request to make to the app to reproduce the issue.

Without us being able to reproduce the issue or you providing a stack trace of an error, we would have to wait for you to provide a pull request to fix the issue, if there is an issue in express.

[brandonburkett]

I did some more digging and oddly, it only seems to do it for me when I run with --debug node flag.

This command does not exit:

PORT=3000 NODE_ENV=development NODE_PATH=. FORCE_COLOR=1 node server.js --color

While this one will exit after a res.status(500).send('whatever')

PORT=3000 NODE_ENV=development NODE_PATH=. FORCE_COLOR=1 node --debug server.js --color

Here's my middleware:

   app.use(function (err, req, res, next) {
        // If the error object doesn't exists
        if (!err) {
            return next();
        }

        // Log it
        logger.error(err);
        if (err.stack) {
            logger.error(err.stack);
        }

        // Error page
        return res.status(err.status || 500).send((['development'].indexOf(process.env.NODE_ENV) !== -1) ? err : {message: 'something went wrong'});
    });

And here is a test API that crashes for me:

    app.route('/api/test').get(function(req, res, next) {
        return next({'message':'test error'});
    });

And here is my terminal output:

error:  
{ message: 'test error' }
Segmentation fault: 11

I am using express 4.13.3 and node 5.3.0. I'll test with node 5.2.x to see if it does the same thing.

[dougwilson]

Ah, a "Segmentation fault: 11". This is a Node.js bug, not an express bug. The way node.js works is that there is no way to cause this, so encountering one means there is something very wrong going on in the node.js core code. Can you open an issue against node.js, link here, and help them with reproducing?

[dougwilson]

Looks like it has already been reported: nodejs/node#4382

[brandonburkett]

Awesome! Thanks for the help on this.

[dougwilson]

No problem! Sounds like it should be addressed in 5.3.1 or 5.4.0, which ever comes first.

[calidion]

@dougwilson I am using v4.2.3.
and it doesn't have stack trace when exit.

[calidion]

and debug is not enabled for me.