Skip to content

Commit 1070777

Browse files
committed
feat(eslint-config-react-app): support eslint-plugin-testing-library 4.x
BREAKING CHANGE: Requires eslint-plugin-testing-library@^4.x
1 parent bbd5a60 commit 1070777

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

packages/eslint-config-react-app/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ This config also ships with optional Jest rules for ESLint (based on [`eslint-pl
3939
You'll first need to add the ESLint plugin for Jest (if you don't already have it installed).
4040

4141
```sh
42-
npm install --save-dev eslint-plugin-jest@^24.0.0 eslint-plugin-testing-library@^3.9.0
42+
npm install --save-dev eslint-plugin-jest@^24.0.0 eslint-plugin-testing-library@^4.0.0
4343
```
4444

4545
You can then enable these rules by adding the Jest config to the `extends` array in your ESLint config.

packages/eslint-config-react-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"eslint-plugin-jsx-a11y": "^6.3.1",
2929
"eslint-plugin-react": "^7.20.3",
3030
"eslint-plugin-react-hooks": "^4.0.8",
31-
"eslint-plugin-testing-library": "^3.9.0"
31+
"eslint-plugin-testing-library": "^3.9.0 || ^4.0.0"
3232
},
3333
"peerDependenciesMeta": {
3434
"eslint-plugin-jest": {

packages/react-error-overlay/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@
4444
"chalk": "2.4.2",
4545
"chokidar": "^3.4.3",
4646
"cross-env": "7.0.2",
47-
"eslint": "^7.11.0",
47+
"eslint": "^7.30.0",
4848
"eslint-config-react-app": "^6.0.0",
49-
"eslint-plugin-flowtype": "^5.2.0",
50-
"eslint-plugin-import": "^2.22.1",
51-
"eslint-plugin-jest": "^24.1.0",
52-
"eslint-plugin-jsx-a11y": "^6.3.1",
53-
"eslint-plugin-react": "^7.21.5",
49+
"eslint-plugin-flowtype": "^5.8.0",
50+
"eslint-plugin-import": "^2.23.4",
51+
"eslint-plugin-jest": "^24.3.6",
52+
"eslint-plugin-jsx-a11y": "^6.4.1",
53+
"eslint-plugin-react": "^7.24.0",
5454
"eslint-plugin-react-hooks": "^4.2.0",
55-
"eslint-plugin-testing-library": "^3.9.2",
55+
"eslint-plugin-testing-library": "^4.9.0",
5656
"flow-bin": "^0.116.0",
5757
"html-entities": "1.3.1",
5858
"jest": "26.6.0",

packages/react-scripts/package.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
"@babel/eslint-parser": "^7.13.14",
3333
"@pmmmwh/react-refresh-webpack-plugin": "0.4.3",
3434
"@svgr/webpack": "5.5.0",
35-
"@typescript-eslint/eslint-plugin": "^4.5.0",
36-
"@typescript-eslint/parser": "^4.5.0",
35+
"@typescript-eslint/eslint-plugin": "^4.28.3",
36+
"@typescript-eslint/parser": "^4.28.3",
3737
"babel-jest": "^26.6.0",
3838
"babel-loader": "^8.1.0",
3939
"babel-plugin-named-asset-import": "^0.3.7",
@@ -44,16 +44,16 @@
4444
"css-loader": "4.3.0",
4545
"dotenv": "8.2.0",
4646
"dotenv-expand": "5.1.0",
47-
"eslint": "^7.11.0",
47+
"eslint": "^7.30.0",
4848
"eslint-config-react-app": "^6.0.0",
49-
"eslint-plugin-flowtype": "^5.2.0",
50-
"eslint-plugin-import": "^2.22.1",
51-
"eslint-plugin-jest": "^24.1.0",
52-
"eslint-plugin-jsx-a11y": "^6.3.1",
53-
"eslint-plugin-react": "^7.21.5",
49+
"eslint-plugin-flowtype": "^5.8.0",
50+
"eslint-plugin-import": "^2.23.4",
51+
"eslint-plugin-jest": "^24.3.6",
52+
"eslint-plugin-jsx-a11y": "^6.4.1",
53+
"eslint-plugin-react": "^7.24.0",
5454
"eslint-plugin-react-hooks": "^4.2.0",
55-
"eslint-plugin-testing-library": "^3.9.2",
56-
"eslint-webpack-plugin": "^2.5.2",
55+
"eslint-plugin-testing-library": "^4.9.0",
56+
"eslint-webpack-plugin": "^2.5.4",
5757
"file-loader": "6.1.1",
5858
"fs-extra": "^9.0.1",
5959
"html-webpack-plugin": "4.5.0",

0 commit comments

Comments
 (0)