Skip to content

Commit 271d5b8

Browse files
committed
Notify rendered in Jest
1 parent d99a17c commit 271d5b8

32 files changed

+64
-96
lines changed

packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@ import load from 'absoluteLoad'
33

44
export default class extends Component {
55
static propTypes = {
6-
notifyRendered: PropTypes.func
7-
}
8-
9-
static defaultProps = {
10-
notifyRendered: () => {}
6+
notifyRendered: PropTypes.func.isRequired
117
}
128

139
constructor(props) {

packages/react-scripts/fixtures/kitchensink/src/features/env/NodePath.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import NodePath from './NodePath';
55
describe('NODE_PATH', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<NodePath />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<NodePath notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArrayDestructuring.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ArrayDestructuring from './ArrayDestructuring';
55
describe('array destructuring', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ArrayDestructuring />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ArrayDestructuring notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ function load(users) {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ArraySpread.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ArraySpread from './ArraySpread';
55
describe('array spread', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ArraySpread />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ArraySpread notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ async function load() {
1111

1212
export default class extends Component {
1313
static propTypes = {
14-
notifyRendered: PropTypes.func
15-
}
16-
17-
static defaultProps = {
18-
notifyRendered: () => {}
14+
notifyRendered: PropTypes.func.isRequired
1915
}
2016

2117
constructor(props) {

packages/react-scripts/fixtures/kitchensink/src/features/syntax/AsyncAwait.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import AsyncAwait from './AsyncAwait';
55
describe('async/await', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<AsyncAwait />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<AsyncAwait notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ import React, { Component, PropTypes } from 'react'
22

33
export default class extends Component {
44
static propTypes = {
5-
notifyRendered: PropTypes.func
6-
}
7-
8-
static defaultProps = {
9-
notifyRendered: () => {}
5+
notifyRendered: PropTypes.func.isRequired
106
}
117

128
users = [

packages/react-scripts/fixtures/kitchensink/src/features/syntax/ClassProperties.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import ClassProperties from './ClassProperties';
55
describe('class properties', () => {
66
it('renders without crashing', () => {
77
const div = document.createElement('div');
8-
ReactDOM.render(<ClassProperties />, div);
8+
return new Promise(resolve => {
9+
ReactDOM.render(<ClassProperties notifyRendered={resolve} />, div);
10+
});
911
});
1012
});

0 commit comments

Comments
 (0)