Skip to content

Commit ab14e01

Browse files
committed
use new babel packages designed for this use-case
1 parent 3fa10be commit ab14e01

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

packages/babel-preset-react-app/helpers/getRequiredPlugins.js

+5-8
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
const {
1010
default: getTargets,
1111
isBrowsersQueryValid,
12-
} = require('@babel/preset-env/lib/targets-parser');
13-
const { isPluginRequired } = require('@babel/preset-env/lib/filter-items');
14-
const data = require('@babel/preset-env/data/plugins.json');
12+
isRequired,
13+
} = require('@babel/helper-compilation-targets');
14+
const data = require('@babel/compat-data/plugins');
1515

1616
// Copying normalizeTargets (because it is not exported)
17-
// https://github.com/babel/babel/blob/7f732ad0198004a1d31543ddd848e6edc646e771/packages/babel-preset-env/src/normalize-options.js#L122-L130
17+
// https://github.com/babel/babel/blob/04354d155689405ba688d4b400702710f9cccc97/packages/babel-preset-env/src/normalize-options.js#L121-L129
1818
const normalizeTargets = targets => {
1919
// TODO: Allow to use only query or strings as a targets from next breaking change.
2020
if (isBrowsersQueryValid(targets)) {
@@ -30,10 +30,7 @@ module.exports = function getRequiredPlugins(targets) {
3030
const requiredPlugins = {};
3131
const currentTargets = getTargets(normalizeTargets(targets));
3232
for (const [pluginName, pluginTargets] of Object.entries(data)) {
33-
requiredPlugins[pluginName] = isPluginRequired(
34-
currentTargets,
35-
pluginTargets
36-
);
33+
requiredPlugins[pluginName] = isRequired(currentTargets, pluginTargets);
3734
}
3835
return requiredPlugins;
3936
};

packages/babel-preset-react-app/package.json

+2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222
"test.js"
2323
],
2424
"dependencies": {
25+
"@babel/compat-data": "7.8.1",
2526
"@babel/core": "7.7.5",
27+
"@babel/helper-compilation-targets": "7.8.3",
2628
"@babel/plugin-proposal-class-properties": "7.7.4",
2729
"@babel/plugin-proposal-decorators": "7.7.4",
2830
"@babel/plugin-proposal-nullish-coalescing-operator": "7.7.4",

0 commit comments

Comments
 (0)