-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Release new version to include #8079? #8254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you're blocked by this, https://www.npmjs.com/package/patch-package works well until a release is cut. |
This is the patch I am using that patch-package created in diff --git a/node_modules/react-dev-utils/webpackHotDevClient.js b/node_modules/react-dev-utils/webpackHotDevClient.js
index fb515f0..b669fd9 100644
--- a/node_modules/react-dev-utils/webpackHotDevClient.js
+++ b/node_modules/react-dev-utils/webpackHotDevClient.js
@@ -59,11 +59,12 @@ if (module.hot && typeof module.hot.dispose === 'function') {
// Connect to WebpackDevServer via a socket.
var connection = new WebSocket(
url.format({
- protocol: 'ws',
+ protocol: window.location.protocol === 'https:' ? 'wss' : 'ws',
hostname: window.location.hostname,
port: window.location.port,
// Hardcoded in WebpackDevServer
pathname: '/sockjs-node',
+ slashes: true,
})
);
|
That’s a cool solution. TIL. Thanks for the tip. I still prefer v3.3.1 to be released with this change, but it’s nice to know this is an option. |
Please. 🙏 This has been blocking us from upgrading to 3.3 for the last month, and I'd love to be able to take advantage of those new capabilities. ( |
Happy to use |
Releasing in the next couple hours. |
Is there a chance we can get this into a release?
The text was updated successfully, but these errors were encountered: