Skip to content

Release new version to include #8079? #8254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chaddjohnson opened this issue Dec 29, 2019 · 7 comments
Closed

Release new version to include #8079? #8254

chaddjohnson opened this issue Dec 29, 2019 · 7 comments

Comments

@chaddjohnson
Copy link

Is there a chance we can get this into a release?

@cheezekurl
Copy link

If you're blocked by this, https://www.npmjs.com/package/patch-package works well until a release is cut.

@lPadier
Copy link

lPadier commented Jan 7, 2020

This is the patch I am using that patch-package created in patches/react-dev-utils+10.0.0.patch

diff --git a/node_modules/react-dev-utils/webpackHotDevClient.js b/node_modules/react-dev-utils/webpackHotDevClient.js
index fb515f0..b669fd9 100644
--- a/node_modules/react-dev-utils/webpackHotDevClient.js
+++ b/node_modules/react-dev-utils/webpackHotDevClient.js
@@ -59,11 +59,12 @@ if (module.hot && typeof module.hot.dispose === 'function') {
 // Connect to WebpackDevServer via a socket.
 var connection = new WebSocket(
   url.format({
-    protocol: 'ws',
+    protocol: window.location.protocol === 'https:' ? 'wss' : 'ws',
     hostname: window.location.hostname,
     port: window.location.port,
     // Hardcoded in WebpackDevServer
     pathname: '/sockjs-node',
+    slashes: true,
   })
 );
 

@esetnik
Copy link

esetnik commented Jan 7, 2020

This is the patch I am using that patch-package created in patches/react-dev-utils+10.0.0.patch

diff --git a/node_modules/react-dev-utils/webpackHotDevClient.js b/node_modules/react-dev-utils/webpackHotDevClient.js
index fb515f0..b669fd9 100644
--- a/node_modules/react-dev-utils/webpackHotDevClient.js
+++ b/node_modules/react-dev-utils/webpackHotDevClient.js
@@ -59,11 +59,12 @@ if (module.hot && typeof module.hot.dispose === 'function') {
 // Connect to WebpackDevServer via a socket.
 var connection = new WebSocket(
   url.format({
-    protocol: 'ws',
+    protocol: window.location.protocol === 'https:' ? 'wss' : 'ws',
     hostname: window.location.hostname,
     port: window.location.port,
     // Hardcoded in WebpackDevServer
     pathname: '/sockjs-node',
+    slashes: true,
   })
 );
 

That’s a cool solution. TIL. Thanks for the tip. I still prefer v3.3.1 to be released with this change, but it’s nice to know this is an option.

@jeremyBanks
Copy link

Please. 🙏 This has been blocking us from upgrading to 3.3 for the last month, and I'd love to be able to take advantage of those new capabilities. (patch-package looks very cool, thanks for the pointer, but we're not willing to use that for prod code.)

@mayteio
Copy link

mayteio commented Jan 9, 2020

Happy to use patch-package, however, is there any indication of when it might get cut just so I can check back and remove the patch? Will it wait for 3.4.0 or will a 3.3.1 version eventually be cut?

@elskwid
Copy link

elskwid commented Jan 19, 2020

FYI, there's a conversation in #8237 about the new release. The milestone is here for those keeping score at home. 😁

@ianschmitz
Copy link
Contributor

Releasing in the next couple hours.

@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants