Skip to content

index.js and serviceWorker.js have link to docs that don't exist #9504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
david-buck opened this issue Aug 18, 2020 · 1 comment
Closed

index.js and serviceWorker.js have link to docs that don't exist #9504

david-buck opened this issue Aug 18, 2020 · 1 comment

Comments

@david-buck
Copy link

david-buck commented Aug 18, 2020

Is your proposal related to a problem?

In index.js there is a comment that ends with

// Learn more about service workers: http://bit.ly/CRA-PWA

in serviceWorker.js there is similarly this comment

// To learn more about the benefits of this model and instructions on how to
// opt-in, read http://bit.ly/CRA-PWA

This link redirects to https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#making-a-progressive-web-app

which then offers a link to

https://github.com/facebook/create-react-app/blob/master/packages/cra-template/template/README.md

which has no mention of PWAs or service workers.

Describe the solution you'd like

Can someone please point the bitly link at the the correct URL. I am unable to find the correct location for the content.

Describe alternatives you've considered

Maybe this is the right link?

https://create-react-app.dev/docs/making-a-progressive-web-app/

Additional context

I'm trying to find out how to make the most use of the service worker functionality in CRA.

@samuelcolvin
Copy link

looks like a duplicate of #9084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants