From 67d923e94c7024a7687240d00312ce2f4467d714 Mon Sep 17 00:00:00 2001 From: James Newell Date: Thu, 17 Nov 2016 11:08:32 +1100 Subject: [PATCH 1/4] Don't strip stack traces of evaluated webpack code --- packages/react-dev-utils/formatWebpackMessages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index d72d5f734ca..657e0eb8150 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -103,7 +103,7 @@ function formatMessage(message) { message = lines.join('\n'); // Internal stacks are generally useless so we strip them message = message.replace( - /^\s*at\s.*:\d+:\d+[\s\)]*\n/gm, '' + /^\s*at\s((?!webpack:).)*:\d+:\d+[\s\)]*\n/gm, '' ); // at ... ...:x:y return message; From 8191ca87ee9ea7607a97a510da1739a5638af302 Mon Sep 17 00:00:00 2001 From: James Newell Date: Thu, 17 Nov 2016 12:40:42 +1100 Subject: [PATCH 2/4] Strip stack traces at the end of a string because the last line doesn't always have a `\n` and `create-react-app` is leaving the last line of the stack traces present in the error messages --- packages/react-dev-utils/formatWebpackMessages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index 657e0eb8150..781a83ef13a 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -103,7 +103,7 @@ function formatMessage(message) { message = lines.join('\n'); // Internal stacks are generally useless so we strip them message = message.replace( - /^\s*at\s((?!webpack:).)*:\d+:\d+[\s\)]*\n/gm, '' + /^\s*at\s((?!webpack:).)*:\d+:\d+[\s\)]*(\n|$)/gm, '' ); // at ... ...:x:y return message; From 632a92aab22d458c126b829d0120991a5290e9ff Mon Sep 17 00:00:00 2001 From: James Newell Date: Mon, 21 Nov 2016 17:37:12 +1100 Subject: [PATCH 3/4] code comment --- packages/react-dev-utils/formatWebpackMessages.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index 781a83ef13a..d97282e08a8 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -101,7 +101,10 @@ function formatMessage(message) { // Reassemble the message. message = lines.join('\n'); - // Internal stacks are generally useless so we strip them + // Internal stacks are generally useless so we strip them... with the + // exception of stacks containing `webpack:` because they're normally + // from user code created by WebPack. For more information see + // https://github.com/facebookincubator/create-react-app/pull/1050 message = message.replace( /^\s*at\s((?!webpack:).)*:\d+:\d+[\s\)]*(\n|$)/gm, '' ); // at ... ...:x:y From d6c76f4b23c6c22baa2c702b64e5abdc35245a04 Mon Sep 17 00:00:00 2001 From: James Newell Date: Mon, 21 Nov 2016 17:38:03 +1100 Subject: [PATCH 4/4] code comment --- packages/react-dev-utils/formatWebpackMessages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dev-utils/formatWebpackMessages.js b/packages/react-dev-utils/formatWebpackMessages.js index d97282e08a8..c40691b7c6b 100644 --- a/packages/react-dev-utils/formatWebpackMessages.js +++ b/packages/react-dev-utils/formatWebpackMessages.js @@ -103,7 +103,7 @@ function formatMessage(message) { message = lines.join('\n'); // Internal stacks are generally useless so we strip them... with the // exception of stacks containing `webpack:` because they're normally - // from user code created by WebPack. For more information see + // from user code generated by WebPack. For more information see // https://github.com/facebookincubator/create-react-app/pull/1050 message = message.replace( /^\s*at\s((?!webpack:).)*:\d+:\d+[\s\)]*(\n|$)/gm, ''