From 6fc06085c9b05ce0eb0e48bd0ddd6340bf616990 Mon Sep 17 00:00:00 2001 From: Luke Kang Date: Tue, 6 Apr 2021 14:39:04 +0900 Subject: [PATCH 1/3] Fix default value of FAST_REFRESH --- packages/react-scripts/config/env.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/config/env.js b/packages/react-scripts/config/env.js index 0ad47cb9779..f677ee599d1 100644 --- a/packages/react-scripts/config/env.js +++ b/packages/react-scripts/config/env.js @@ -97,7 +97,7 @@ function getClientEnvironment(publicUrl) { // react-refresh is not 100% stable at this time, // which is why it's disabled by default. // It is defined here so it is available in the webpackHotDevClient. - FAST_REFRESH: process.env.FAST_REFRESH !== 'false', + FAST_REFRESH: process.env.FAST_REFRESH === 'true', } ); // Stringify all values so we can feed into webpack DefinePlugin From 199dbb9fa1661d860e03478f0e4e2aab3ac979f8 Mon Sep 17 00:00:00 2001 From: Luke Kang Date: Tue, 6 Apr 2021 16:22:14 +0900 Subject: [PATCH 2/3] Revert "Fix default value of FAST_REFRESH" This reverts commit 6fc06085c9b05ce0eb0e48bd0ddd6340bf616990. --- packages/react-scripts/config/env.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/config/env.js b/packages/react-scripts/config/env.js index f677ee599d1..0ad47cb9779 100644 --- a/packages/react-scripts/config/env.js +++ b/packages/react-scripts/config/env.js @@ -97,7 +97,7 @@ function getClientEnvironment(publicUrl) { // react-refresh is not 100% stable at this time, // which is why it's disabled by default. // It is defined here so it is available in the webpackHotDevClient. - FAST_REFRESH: process.env.FAST_REFRESH === 'true', + FAST_REFRESH: process.env.FAST_REFRESH !== 'false', } ); // Stringify all values so we can feed into webpack DefinePlugin From 2be567bf2ae8b47f9f08919cb722a316300c8049 Mon Sep 17 00:00:00 2001 From: Luke Kang Date: Tue, 6 Apr 2021 16:23:39 +0900 Subject: [PATCH 3/3] Remove outdated comments on react-refresh --- packages/react-scripts/config/env.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/react-scripts/config/env.js b/packages/react-scripts/config/env.js index 0ad47cb9779..4d134a0aa07 100644 --- a/packages/react-scripts/config/env.js +++ b/packages/react-scripts/config/env.js @@ -94,8 +94,6 @@ function getClientEnvironment(publicUrl) { WDS_SOCKET_PATH: process.env.WDS_SOCKET_PATH, WDS_SOCKET_PORT: process.env.WDS_SOCKET_PORT, // Whether or not react-refresh is enabled. - // react-refresh is not 100% stable at this time, - // which is why it's disabled by default. // It is defined here so it is available in the webpackHotDevClient. FAST_REFRESH: process.env.FAST_REFRESH !== 'false', }